From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UtvLw-0000yg-N3
	for qemu-devel@nongnu.org; Tue, 02 Jul 2013 03:50:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UtvLv-0003Op-0j
	for qemu-devel@nongnu.org; Tue, 02 Jul 2013 03:50:20 -0400
Received: from mail-we0-x231.google.com ([2a00:1450:400c:c03::231]:32921)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UtvLu-0003Og-R0
	for qemu-devel@nongnu.org; Tue, 02 Jul 2013 03:50:18 -0400
Received: by mail-we0-f177.google.com with SMTP id m19so3883303wev.8
	for <qemu-devel@nongnu.org>; Tue, 02 Jul 2013 00:50:18 -0700 (PDT)
Date: Tue, 2 Jul 2013 09:50:15 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130702075015.GF6800@stefanha-thinkpad.redhat.com>
References: <1372671341-19855-1-git-send-email-stefanha@redhat.com>
	<1372671341-19855-3-git-send-email-stefanha@redhat.com>
	<CAPyFy2BKNdPPHCMhTYGp-HddHubhYbJnP+eNqDDOu73eJtn3+g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPyFy2BKNdPPHCMhTYGp-HddHubhYbJnP+eNqDDOu73eJtn3+g@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-thread: add TLS wrappers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ed Maste <emaste@freebsd.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

On Mon, Jul 01, 2013 at 02:52:08PM -0400, Ed Maste wrote:
>  On 1 July 2013 05:35, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > From: Paolo Bonzini <pbonzini@redhat.com>
> >
> > Fast TLS is not available on some platforms, but it is always nice to
> > use it.  This wrapper implementation falls back to pthread_get/setspecific
> > on POSIX systems that lack __thread, but uses the dynamic linker's TLS
> > support on Linux and Windows.
> 
> The most recent version of this patch posted by Paolo that I see has:
> 
> +#if defined(__linux__) || defined(__FreeBSD__)
> +#define DECLARE_TLS(type, x)                     \
> 
> while this one has only __linux__.  Do you mind picking up that
> change, if this is likely to make it in via your work?

Since additional changes are necessary before these patches can be
merged, I hope Paolo can pick up my "tls_" rename and send the next
revision including his improvements.

Stefan