From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uu17s-0002Z1-41 for qemu-devel@nongnu.org; Tue, 02 Jul 2013 10:00:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uu17l-0007Yv-Av for qemu-devel@nongnu.org; Tue, 02 Jul 2013 10:00:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uu0st-0008Tx-73 for qemu-devel@nongnu.org; Tue, 02 Jul 2013 09:44:43 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r62Difmw024201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 2 Jul 2013 09:44:42 -0400 Date: Tue, 2 Jul 2013 15:44:40 +0200 From: Stefan Hajnoczi Message-ID: <20130702134440.GC9870@stefanha-thinkpad.redhat.com> References: <1372749561-11117-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372749561-11117-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] curl: refuse to open URL from HTTP server without range support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, rjones@redhat.com On Tue, Jul 02, 2013 at 03:19:21PM +0800, Fam Zheng wrote: > CURL driver requests partial data from server on guest IO req. For HTTP > and HTTPS, it uses "Range: ***" in requests, and this will not work if > server not accepting range. This patch does this check when open. > > * Removed curl_size_cb, which is not used: On one hand it's registered to > libcurl as CURLOPT_WRITEFUNCTION, instead of CURLOPT_HEADERFUNCTION, > which will get called with *data*, not *header*. On the other hand the > s->len is assigned unconditionally later. > > In this gone function, the sscanf for "Content-Length: %zd", on > (void *)ptr, which is not guaranteed to be zero-terminated, is > potentially a security bug. So this patch fixes it as a side-effect. The > bug is reported as: https://bugs.launchpad.net/qemu/+bug/1188943 > (Note the bug is marked "private" so you might not be able to see it) > > * Introduced curl_header_cb, which is used to parse header and mark the > server as accepting range if "Accept-Ranges: bytes" line is seen from > response header. If protocol is HTTP or HTTPS, but server response has > no not this support, refuse to open this URL. > > Note that python builtin module SimpleHTTPServer is an example of not > supporting range, if you need to test this driver, get a better server > or use internet URLs. > > Signed-off-by: Fam Zheng > > --- > > v3: Fix copy&paste error. > Improve error text as suggested by Rich. > > --- > > block/curl.c | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan