From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, lilei@linux.vnet.ibm.com,
qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes
Date: Wed, 3 Jul 2013 10:55:19 -0400 [thread overview]
Message-ID: <20130703105519.427e0b60@redhat.com> (raw)
In-Reply-To: <1372342930-28684-1-git-send-email-armbru@redhat.com>
On Thu, 27 Jun 2013 16:22:06 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> The first patch is a straightforward bug fix.
>
> The rest fix code to match documentation. The patches take pains to
> preserve command-line, HMP and QMP bug-compatibility. I'm not sure
> that's actually needed, because:
>
> * All: the documented way to use the driver never worked in any
> released version, and the way that worked was undocumented.
>
> * QMP: I doubt anyone used chardev-add / chardev-remove in anger,
> because serious use surely would've run into the "qemu-char: Fix ID
> reuse after chardev-remove for qapi-based init" bug.
>
> I include the compatibility gunk anyway, so we can have a more
> informed discussion.
Series looks good to me, but patch 3/4 doesn't apply anymore.
I've applied patch 1/4 anyway.
prev parent reply other threads:[~2013-07-03 15:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 14:22 [Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes Markus Armbruster
2013-06-27 14:22 ` [Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size Markus Armbruster
2013-06-27 23:17 ` Eric Blake
2013-07-03 14:54 ` Luiz Capitulino
2013-06-27 14:22 ` [Qemu-devel] [PATCH 2/4] Revert "chardev: Make the name of memory device consistent" Markus Armbruster
2013-06-28 3:35 ` Lei Li
2013-06-28 7:15 ` Markus Armbruster
2013-06-27 14:22 ` [Qemu-devel] [PATCH 3/4] qemu-char: Register ring buffer driver with correct name "ringbuf" Markus Armbruster
2013-07-03 14:54 ` Luiz Capitulino
2013-07-04 6:30 ` Markus Armbruster
2013-06-27 14:22 ` [Qemu-devel] [PATCH 4/4] qapi: Rename ChardevBackend member "memory" to "ringbuf" Markus Armbruster
2013-06-28 13:37 ` Eric Blake
2013-06-28 17:19 ` Markus Armbruster
2013-07-01 3:08 ` Amos Kong
2013-07-01 8:10 ` Markus Armbruster
2013-07-01 9:00 ` Amos Kong
2013-07-01 9:28 ` Markus Armbruster
2013-07-01 11:17 ` Amos Kong
2013-07-01 16:08 ` Markus Armbruster
2013-07-01 12:52 ` Anthony Liguori
2013-07-03 14:55 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703105519.427e0b60@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).