From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuObo-00024H-0m for qemu-devel@nongnu.org; Wed, 03 Jul 2013 11:04:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UuObm-0003UA-QO for qemu-devel@nongnu.org; Wed, 03 Jul 2013 11:04:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuOT9-0000Zv-V8 for qemu-devel@nongnu.org; Wed, 03 Jul 2013 10:55:44 -0400 Date: Wed, 3 Jul 2013 10:55:19 -0400 From: Luiz Capitulino Message-ID: <20130703105519.427e0b60@redhat.com> In-Reply-To: <1372342930-28684-1-git-send-email-armbru@redhat.com> References: <1372342930-28684-1-git-send-email-armbru@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aliguori@us.ibm.com, lilei@linux.vnet.ibm.com, qemu-devel@nongnu.org, kraxel@redhat.com On Thu, 27 Jun 2013 16:22:06 +0200 Markus Armbruster wrote: > The first patch is a straightforward bug fix. > > The rest fix code to match documentation. The patches take pains to > preserve command-line, HMP and QMP bug-compatibility. I'm not sure > that's actually needed, because: > > * All: the documented way to use the driver never worked in any > released version, and the way that worked was undocumented. > > * QMP: I doubt anyone used chardev-add / chardev-remove in anger, > because serious use surely would've run into the "qemu-char: Fix ID > reuse after chardev-remove for qapi-based init" bug. > > I include the compatibility gunk anyway, so we can have a more > informed discussion. Series looks good to me, but patch 3/4 doesn't apply anymore. I've applied patch 1/4 anyway.