From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uuf1i-0004Qg-63 for qemu-devel@nongnu.org; Thu, 04 Jul 2013 04:36:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uuf1a-0005pd-R7 for qemu-devel@nongnu.org; Thu, 04 Jul 2013 04:36:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uuf1a-0005pQ-JA for qemu-devel@nongnu.org; Thu, 04 Jul 2013 04:36:22 -0400 Date: Thu, 4 Jul 2013 11:37:25 +0300 From: "Michael S. Tsirkin" Message-ID: <20130704083725.GC29342@redhat.com> References: <1372754385-10186-1-git-send-email-paul.durrant@citrix.com> <51D2AF66.8000507@suse.de> <51D2B156.2080103@redhat.com> <9AAE0902D5BC7E449B7C8E4E778ABCD00578E1@LONPEX01CL01.citrite.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Citrix PV Bus device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Paul Durrant , "xen-devel@lists.xen.org" , Andreas =?iso-8859-1?Q?F=E4rber?= , "qemu-devel@nongnu.org" On Tue, Jul 02, 2013 at 12:10:17PM +0100, Peter Maydell wrote: > On 2 July 2013 11:57, Paul Durrant wrote: > >> -----Original Message----- > >> From: Paolo Bonzini [mailto:pbonzini@redhat.com] > >> > So the reason to place the device here is TARGET_PAGE_SIZE... > >> > We really need a way to access that value from common code, > >> > somewhere down my TODO list. :/ > > We probably don't, because it generally doesn't mean what you > think it does. It's the smallest possible page size the guest > CPU supports, which may not be the same as the actual page > size the guest OS is using. > > >> Why does it need to be in pages rather than bytes? > > > It doesn't necessarily need to be in pages; it's just a more > > convenient quantity than bytes. > > It isn't really more convienient, because the guest would have > to tell QEMU what the page size was. (I'm told that virtio is > planning to move to a simple "just use a byte count" approach.) > > thanks > -- PMM Yes, sometime in a distant future ...