From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uuk7K-0005ko-Ny for qemu-devel@nongnu.org; Thu, 04 Jul 2013 10:02:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uuk7H-0003sS-O4 for qemu-devel@nongnu.org; Thu, 04 Jul 2013 10:02:38 -0400 Received: from mail-ea0-x22a.google.com ([2a00:1450:4013:c01::22a]:42245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uuk7H-0003sE-IM for qemu-devel@nongnu.org; Thu, 04 Jul 2013 10:02:35 -0400 Received: by mail-ea0-f170.google.com with SMTP id h10so837003eaj.1 for ; Thu, 04 Jul 2013 07:02:34 -0700 (PDT) Date: Thu, 4 Jul 2013 16:02:31 +0200 From: Stefan Hajnoczi Message-ID: <20130704140231.GI4213@stefanha-thinkpad.redhat.com> References: <1372744789-997-1-git-send-email-famz@redhat.com> <1372744789-997-5-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372744789-997-5-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/7] block: simplify bdrv_drop_intermediate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, obarenbo@redhat.com, armbru@redhat.com, roliveri@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, pmyers@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Tue, Jul 02, 2013 at 01:59:46PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block.c | 71 ++++++++++------------------------------------------------------- > 1 file changed, 11 insertions(+), 60 deletions(-) Way too big for no commit description. Okay, I admit I jumped into this patch and didn't review all the previous ones - maybe it would have been obvious if I had read them linearly :). Should the description be something like "We no longer need to a keep a list because refcounts ..."?