From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuuNx-0008Ue-5C for qemu-devel@nongnu.org; Thu, 04 Jul 2013 21:00:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UuuNs-0003ws-KO for qemu-devel@nongnu.org; Thu, 04 Jul 2013 21:00:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuuNs-0003wg-Ck for qemu-devel@nongnu.org; Thu, 04 Jul 2013 21:00:24 -0400 Date: Fri, 5 Jul 2013 09:00:11 +0800 From: Fam Zheng Message-ID: <20130705010011.GC1570@T430s.nay.redhat.com> References: <1372744789-997-1-git-send-email-famz@redhat.com> <1372744789-997-5-git-send-email-famz@redhat.com> <20130704140231.GI4213@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130704140231.GI4213@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/7] block: simplify bdrv_drop_intermediate Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, rjones@redhat.com, obarenbo@redhat.com, roliveri@redhat.com, hbrock@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pmyers@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Thu, 07/04 16:02, Stefan Hajnoczi wrote: > On Tue, Jul 02, 2013 at 01:59:46PM +0800, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > block.c | 71 ++++++++++------------------------------------------------------- > > 1 file changed, 11 insertions(+), 60 deletions(-) > > Way too big for no commit description. Okay, I admit I jumped into this > patch and didn't review all the previous ones - maybe it would have been > obvious if I had read them linearly :). > > Should the description be something like "We no longer need to a keep a > list because refcounts ..."? > Yes, will add a decent message. Thanks. -- Fam