From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UvQrR-0003xB-CX for qemu-devel@nongnu.org; Sat, 06 Jul 2013 07:41:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UvQrN-000760-0g for qemu-devel@nongnu.org; Sat, 06 Jul 2013 07:41:05 -0400 Received: from indium.canonical.com ([91.189.90.7]:43850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UvQrM-00075o-Re for qemu-devel@nongnu.org; Sat, 06 Jul 2013 07:41:00 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1UvQrL-0007DD-Am for ; Sat, 06 Jul 2013 11:40:59 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 4DAF32E8014 for ; Sat, 6 Jul 2013 11:40:59 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Sat, 06 Jul 2013 11:34:53 -0000 From: Adolfo Jayme Barrientos Sender: bounces@canonical.com References: <20100522092104.29268.17427.malonedeb@soybean.canonical.com> Message-Id: <20130706113453.4189.9366.launchpad@soybean.canonical.com> Errors-To: bounces@canonical.com Subject: [Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number Reply-To: Bug 584143 <584143@bugs.launchpad.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ** No longer affects: qemu-kvm (Ubuntu Lucid) ** No longer affects: qemu-kvm (Ubuntu Maverick) -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/584143 Title: qemu fails to set hdd serial number Status in QEMU: Fix Released Status in =E2=80=9Cqemu-kvm=E2=80=9D package in Ubuntu: Fix Released Status in =E2=80=9Cqemu-kvm=E2=80=9D package in Debian: Fix Released Bug description: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D SRU Justification: 1. Impact: 'qemu -drive ...,serial=3Dxyz' does not work 2. How addressed: a patch from upstream fixes bug that sizeof was called = on the wrong thing. 3. patch: is in the description 4. to reproduce: use '-drive ...,serial=3Dxyz' option to qemu 5. regression potential: this only changes one line which called sizeof = on the wrong thing, so should not impact any other code. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D The -drive ...,serial=3Dxyz option is broken, at least in 0.12. See Debian bug#573439, http://bugs.debian.org/cgi- bin/bugreport.cgi?bug=3D573439 for details. The proposed fix from the original reporter: --- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900 +++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900 @@ -2397,7 +2397,7 @@ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0dinfo->on_write_error =3D on_write_error; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0dinfo->opts =3D opts; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (serial) - strncpy(dinfo->serial, serial, sizeof(serial)); + strncpy(dinfo->serial, serial, sizeof(dinfo->serial)); =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0QTAILQ_INSERT_TAIL(&drives, dinfo, next); =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (is_extboot) { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0extboot_drive =3D d= info; To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/584143/+subscriptions