From: David Gibson <david@gibson.dropbear.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [Qemu-devel] [PATCH 14/17] pseries: Support for in-kernel XICS interrupt controller
Date: Tue, 9 Jul 2013 17:21:45 +1000 [thread overview]
Message-ID: <20130709072145.GI2696@voom.redhat.com> (raw)
In-Reply-To: <51DB81B7.9040807@ozlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Tue, Jul 09, 2013 at 01:21:27PM +1000, Alexey Kardashevskiy wrote:
> On 07/09/2013 04:50 AM, Anthony Liguori wrote:
> >> +#include "hw/hw.h"
> >> +#include "trace.h"
> >> +#include "hw/ppc/spapr.h"
> >> +#include "hw/ppc/xics.h"
> >> +#include "kvm_ppc.h"
> >> +#include "qemu/config-file.h"
> >> +
> >> +#include <sys/ioctl.h>
> >> +
> >> +struct icp_state_kvm {
> >
> > CodingStyle
>
>
> ./scripts/checkpatch.pl finds nothing.
>
> Did you mean missing typedef?
I think he means the kernel_style_struct_name instead of the
QemuStyleStudlyCapsStructName.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-07-09 9:32 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 6:45 [Qemu-devel] [PATCH 00/17 v3] spapr: migration, pci, msi, power8 Alexey Kardashevskiy
2013-06-27 6:45 ` [Qemu-devel] [PATCH 01/17] pseries: move interrupt controllers to hw/intc/ Alexey Kardashevskiy
2013-07-02 20:54 ` Andreas Färber
2013-07-08 18:15 ` Anthony Liguori
2013-07-08 18:34 ` Alexander Graf
2013-06-27 6:45 ` [Qemu-devel] [PATCH 02/17] pseries: rework XICS Alexey Kardashevskiy
2013-06-27 11:47 ` David Gibson
2013-06-27 12:17 ` Alexey Kardashevskiy
2013-07-02 0:06 ` David Gibson
2013-07-02 0:21 ` Alexander Graf
2013-07-02 2:08 ` Alexey Kardashevskiy
2013-07-08 18:24 ` Anthony Liguori
2013-07-08 18:22 ` Anthony Liguori
2013-07-09 3:40 ` Alexey Kardashevskiy
2013-07-09 4:48 ` Benjamin Herrenschmidt
2013-07-09 13:58 ` Anthony Liguori
2013-07-10 3:06 ` Alexey Kardashevskiy
2013-07-10 3:26 ` Benjamin Herrenschmidt
2013-07-10 12:09 ` Anthony Liguori
2013-06-27 6:45 ` [Qemu-devel] [PATCH 03/17] savevm: Implement VMS_DIVIDE flag Alexey Kardashevskiy
2013-07-08 18:27 ` Anthony Liguori
2013-07-08 23:57 ` David Gibson
2013-07-09 14:06 ` Anthony Liguori
2013-07-09 14:38 ` David Gibson
2013-06-27 6:45 ` [Qemu-devel] [PATCH 04/17] target-ppc: Convert ppc cpu savevm to VMStateDescription Alexey Kardashevskiy
2013-07-08 18:29 ` Anthony Liguori
2013-07-09 5:14 ` Alexey Kardashevskiy
2013-07-09 14:08 ` Anthony Liguori
2013-07-09 15:11 ` David Gibson
2013-07-10 3:31 ` Benjamin Herrenschmidt
2013-07-10 7:49 ` David Gibson
2013-07-15 13:24 ` Paolo Bonzini
2013-06-27 6:45 ` [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller Alexey Kardashevskiy
2013-07-08 18:31 ` Anthony Liguori
2013-07-09 0:06 ` Alexey Kardashevskiy
2013-07-09 0:49 ` Anthony Liguori
2013-07-09 0:59 ` Alexey Kardashevskiy
2013-07-09 1:25 ` Anthony Liguori
2013-07-09 3:37 ` Alexey Kardashevskiy
2013-07-15 13:05 ` Paolo Bonzini
2013-07-15 13:13 ` Alexey Kardashevskiy
2013-07-15 13:17 ` Paolo Bonzini
2013-07-09 7:17 ` David Gibson
2013-07-15 13:10 ` Paolo Bonzini
2013-06-27 6:45 ` [Qemu-devel] [PATCH 06/17] pseries: savevm support for VIO devices Alexey Kardashevskiy
2013-07-08 18:35 ` Anthony Liguori
2013-06-27 6:45 ` [Qemu-devel] [PATCH 07/17] pseries: savevm support for PAPR VIO logical lan Alexey Kardashevskiy
2013-07-08 18:36 ` Anthony Liguori
2013-06-27 6:45 ` [Qemu-devel] [PATCH 08/17] pseries: savevm support for PAPR TCE tables Alexey Kardashevskiy
2013-07-08 18:39 ` Anthony Liguori
2013-07-08 21:45 ` Benjamin Herrenschmidt
2013-07-08 22:15 ` Anthony Liguori
2013-07-08 22:41 ` Benjamin Herrenschmidt
2013-07-09 7:20 ` David Gibson
2013-07-09 15:22 ` Anthony Liguori
2013-07-10 7:42 ` David Gibson
2013-07-09 16:26 ` Anthony Liguori
2013-07-15 13:26 ` Paolo Bonzini
2013-07-15 15:06 ` Anthony Liguori
2013-06-27 6:45 ` [Qemu-devel] [PATCH 09/17] pseries: rework PAPR virtual SCSI Alexey Kardashevskiy
2013-07-08 18:42 ` Anthony Liguori
2013-07-15 13:11 ` Paolo Bonzini
2013-06-27 6:45 ` [Qemu-devel] [PATCH 10/17] pseries: savevm support for " Alexey Kardashevskiy
2013-06-27 6:45 ` [Qemu-devel] [PATCH 11/17] pseries: savevm support for pseries machine Alexey Kardashevskiy
2013-07-08 18:45 ` Anthony Liguori
2013-07-08 18:50 ` Alexander Graf
2013-07-08 19:01 ` Anthony Liguori
2013-07-08 21:48 ` Benjamin Herrenschmidt
2013-07-08 22:23 ` Anthony Liguori
2013-06-27 6:45 ` [Qemu-devel] [PATCH 12/17] pseries: savevm support for PCI host bridge Alexey Kardashevskiy
2013-07-08 18:45 ` Anthony Liguori
2013-06-27 6:45 ` [Qemu-devel] [PATCH 13/17] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN Alexey Kardashevskiy
2013-06-27 6:45 ` [Qemu-devel] [PATCH 14/17] pseries: Support for in-kernel XICS interrupt controller Alexey Kardashevskiy
2013-07-08 18:50 ` Anthony Liguori
2013-07-09 3:21 ` Alexey Kardashevskiy
2013-07-09 7:21 ` David Gibson [this message]
2013-07-10 3:24 ` Benjamin Herrenschmidt
2013-07-10 7:48 ` David Gibson
2013-06-27 6:45 ` [Qemu-devel] [PATCH 15/17] pseries: savevm support with KVM Alexey Kardashevskiy
2013-06-27 6:45 ` [Qemu-devel] [PATCH 16/17] ppc64: Enable QEMU to run on POWER 8 DD1 chip Alexey Kardashevskiy
2013-07-04 5:54 ` Andreas Färber
2013-07-04 6:26 ` [Qemu-devel] [Qemu-ppc] " Benjamin Herrenschmidt
2013-07-04 6:42 ` [Qemu-devel] " Prerna Saxena
2013-07-10 11:19 ` Alexander Graf
2013-06-27 6:46 ` [Qemu-devel] [PATCH 17/17] spapr-pci: rework MSI/MSIX Alexey Kardashevskiy
2013-07-04 2:31 ` [Qemu-devel] [PATCH 00/17 v3] spapr: migration, pci, msi, power8 Alexey Kardashevskiy
2013-07-04 2:40 ` Anthony Liguori
2013-07-04 2:48 ` Alexey Kardashevskiy
2013-07-08 18:01 ` Anthony Liguori
2013-07-09 6:37 ` Alexey Kardashevskiy
2013-07-09 15:26 ` Anthony Liguori
2013-07-09 14:04 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709072145.GI2696@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=aliguori@us.ibm.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).