From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51020)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1UwUHM-0005jL-8o
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 05:32:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1UwUHI-0000EZ-5r
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 05:32:12 -0400
Date: Tue, 9 Jul 2013 17:21:45 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20130709072145.GI2696@voom.redhat.com>
References: <1372315560-5478-1-git-send-email-aik@ozlabs.ru>
	<1372315560-5478-15-git-send-email-aik@ozlabs.ru>
	<87hag4zy1p.fsf@codemonkey.ws> <51DB81B7.9040807@ozlabs.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="GBuTPvBEOL0MYPgd"
Content-Disposition: inline
In-Reply-To: <51DB81B7.9040807@ozlabs.ru>
Subject: Re: [Qemu-devel] [PATCH 14/17] pseries: Support for in-kernel XICS
 interrupt controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Paul Mackerras <paulus@samba.org>


--GBuTPvBEOL0MYPgd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 09, 2013 at 01:21:27PM +1000, Alexey Kardashevskiy wrote:
> On 07/09/2013 04:50 AM, Anthony Liguori wrote:
> >> +#include "hw/hw.h"
> >> +#include "trace.h"
> >> +#include "hw/ppc/spapr.h"
> >> +#include "hw/ppc/xics.h"
> >> +#include "kvm_ppc.h"
> >> +#include "qemu/config-file.h"
> >> +
> >> +#include <sys/ioctl.h>
> >> +
> >> +struct icp_state_kvm {
> >=20
> > CodingStyle
>=20
>=20
> ./scripts/checkpatch.pl finds nothing.
>=20
> Did you mean missing typedef?

I think he means the kernel_style_struct_name instead of the
QemuStyleStudlyCapsStructName.

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--GBuTPvBEOL0MYPgd
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)

iEYEARECAAYFAlHbugkACgkQaILKxv3ab8a4fwCfR53vZGkyXTX3VAsu4TvZ5cS6
BgUAoI5+iEerTkHGoJ2UgpwUPw4eR+A0
=0d8M
-----END PGP SIGNATURE-----

--GBuTPvBEOL0MYPgd--