From: Luiz Capitulino <lcapitulino@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions
Date: Tue, 9 Jul 2013 10:14:39 -0400 [thread overview]
Message-ID: <20130709101439.4e1d45b3@redhat.com> (raw)
In-Reply-To: <51DC183E.4020409@linux.vnet.ibm.com>
On Tue, 09 Jul 2013 22:03:42 +0800
Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
>
> >> You could pass cur_mon to readline_completion() in readline_handle_byte()
> >> to avoid all this, but it would be preferable to clarify the matter.
> >>
> >> This is also another benefit of having readline_completion() in a
> >> different patch, you can (and should!) clarify this point in the commit
> >> log along with testing results.
> >>
> > OK, I'll test multiple monitors case.
> >
> >
> >
> Do you have an example about how invoke qemu with multiple monitor?
> Do you have recommendation about the way to connect to qemu's moniotr?
> I tried pty with minicom but it seems not good, so wonder your method.
You can open telnet sessions:
-monitor tcp:0:4444,server,nowait,telnet \
-monitor tcp:0:4445,server,nowait,telnet
But note that, besides testing, I'd like to see an explanation on
the commitlog as to why dropping cur_mon doesn't brake the current
code.
next prev parent reply other threads:[~2013-07-09 14:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 3:52 [Qemu-devel] [PATCH V5 0/7] monitor: support sub command group in auto completion and help Wenchao Xia
2013-06-29 3:52 ` [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions Wenchao Xia
2013-07-08 15:17 ` Luiz Capitulino
2013-07-09 2:06 ` Wenchao Xia
2013-07-09 14:03 ` Wenchao Xia
2013-07-09 14:14 ` Luiz Capitulino [this message]
2013-07-10 6:06 ` Wenchao Xia
2013-06-29 3:52 ` [Qemu-devel] [PATCH V5 2/7] monitor: avoid direct use of global variable *mon_cmds Wenchao Xia
2013-07-08 15:29 ` Luiz Capitulino
2013-06-29 3:52 ` [Qemu-devel] [PATCH V5 3/7] monitor: code move for parse_cmdline() Wenchao Xia
2013-07-08 15:26 ` Luiz Capitulino
2013-06-29 3:52 ` [Qemu-devel] [PATCH V5 4/7] monitor: avoid direct use of global *info_cmds in help functions Wenchao Xia
2013-07-08 15:45 ` Luiz Capitulino
2013-07-10 6:45 ` Wenchao Xia
2013-06-29 3:52 ` [Qemu-devel] [PATCH V5 5/7] monitor: support sub commands in auto completion Wenchao Xia
2013-06-29 3:53 ` [Qemu-devel] [PATCH V5 6/7] monitor: improve "help" in auto completion for sub command Wenchao Xia
2013-07-08 16:09 ` Luiz Capitulino
2013-07-10 6:46 ` Wenchao Xia
2013-06-29 3:53 ` [Qemu-devel] [PATCH V5 7/7] monitor: improve "help" to allow show details of single command in sub group Wenchao Xia
2013-07-08 16:17 ` Luiz Capitulino
2013-07-10 6:47 ` Wenchao Xia
2013-07-07 22:39 ` [Qemu-devel] [PATCH V5 0/7] monitor: support sub command group in auto completion and help Wenchao Xia
2013-07-08 13:33 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709101439.4e1d45b3@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).