From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwXIP-000611-Rw for qemu-devel@nongnu.org; Tue, 09 Jul 2013 08:45:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwXIN-0001Pw-4O for qemu-devel@nongnu.org; Tue, 09 Jul 2013 08:45:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwXIM-0001Pn-SX for qemu-devel@nongnu.org; Tue, 09 Jul 2013 08:45:27 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r69CjOGF028471 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Jul 2013 08:45:25 -0400 Date: Tue, 9 Jul 2013 20:45:23 +0800 From: Fam Zheng Message-ID: <20130709124523.GC2910@T430s.nay.redhat.com> References: <1373357135-9294-1-git-send-email-kwolf@redhat.com> <20130709115808.GB2910@T430s.nay.redhat.com> <51DBFCF6.1010809@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51DBFCF6.1010809@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , qemu-devel@nongnu.org, lcapitulino@redhat.com On Tue, 07/09 06:07, Eric Blake wrote: > On 07/09/2013 05:58 AM, Fam Zheng wrote: > > On Tue, 07/09 10:05, Kevin Wolf wrote: > >> This removes duplicated definitions and documentation by reusing the > >> existing data type. > >> > >> Signed-off-by: Kevin Wolf > >> --- > > >> +++ b/qapi-schema.json > >> @@ -1791,42 +1791,14 @@ > >> # The operation can be stopped before it has completed using the > >> # block-job-cancel command. > >> # > > Are these lines, ... > > >> -# actions will be used. > >> +# For the arguments, see the documentation of DriveBackup. > >> # > >> # Returns: nothing on success > >> # If @device is not a valid block device, DeviceNotFound > >> # > >> # Since 1.6 > >> ## > > and these still duplication of those comments for type declaration? > > Are you talking about the lines that were elided or the lines that > remain? The lines that were elided are duplicates of the documentation I thought there was a duplication for the remaining. Kevin explained that too. Thanks. > of the DriveBackup struct; the lines that remain (command overview, > Returns, and Since designations) must remain because they independently > document the 'drive-backup' command. The trivial amount of remaining > duplication (basically, the Since 1.6 line) matches what was already > done for the blockdev-snapshot-sync command, because every entity (both > types and commands) should mention when they were introduced. I see no > problem with the patch. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Fam