From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwZ59-0004Eb-Rm for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:40:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwZ55-0001WU-1Q for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:39:55 -0400 Date: Wed, 10 Jul 2013 00:38:59 +1000 From: David Gibson Message-ID: <20130709143859.GK2696@voom.redhat.com> References: <1372315560-5478-1-git-send-email-aik@ozlabs.ru> <1372315560-5478-4-git-send-email-aik@ozlabs.ru> <877gh029hi.fsf@codemonkey.ws> <20130708235701.GE2696@voom.redhat.com> <87txk34yle.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QxIEt88oQPsT6QmF" Content-Disposition: inline In-Reply-To: <87txk34yle.fsf@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH 03/17] savevm: Implement VMS_DIVIDE flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Alexey Kardashevskiy , qemu-devel@nongnu.org, Alexander Graf , qemu-ppc@nongnu.org, Paolo Bonzini , Paul Mackerras --QxIEt88oQPsT6QmF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 09, 2013 at 09:06:21AM -0500, Anthony Liguori wrote: > David Gibson writes: >=20 > > On Mon, Jul 08, 2013 at 01:27:05PM -0500, Anthony Liguori wrote: > >> Alexey Kardashevskiy writes: > >>=20 > >> > From: David Gibson > >> > > >> > The vmstate infrastructure includes a VMS_MULTIPY flag, and associat= ed > >> > VMSTATE_VBUFFER_MULTIPLY helper macro. These can be used to save a > >> > variably sized buffer where the size in bytes of the buffer isn't di= rectly > >> > accessible as a structure field, but an element count from which the= size > >> > can be derived is. > >>=20 > >> Why? What's the point of sending the total size vs. the element > >> count? > > > > Because it's more convenient to work with the total size at runtime, > > and because the VMSTATE stuff works with actual structure fields, > > there's not really a way to convert it at migrate time, short of this. >=20 > The only thing I see using it is the tce array which is broken > anyway. It's only broken due to a bug elsewhere. Whatever is done there it will still be some sort of VBUFFER arrangement, and the window will still be a more convenient thing to work with than the number of entries. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --QxIEt88oQPsT6QmF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) iEYEARECAAYFAlHcIIMACgkQaILKxv3ab8aS4QCfTj8Gd6yyIL0x3lV2dBPIgGvY sDEAn11kXEo7LfG734AemL7/vrybeMMI =wIF7 -----END PGP SIGNATURE----- --QxIEt88oQPsT6QmF--