From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33647)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UweTz-0008AW-BD
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 16:25:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UweTw-0005G1-3z
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 16:25:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UweTv-0005Fn-T9
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 16:25:52 -0400
Date: Tue, 9 Jul 2013 23:27:00 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130709202700.GA30219@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] win7 boot failure with commit f68ec83 - ide: Set BSY
	bit during FLUSH
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Stefan Hajnoczi <stefanha@redhat.com>

Hi!
I am using this command line:
qemu-system-x86_64 -m 512 -enable-kvm -drive
id=3Ddisk,file=3D./images/win7-x86.qcow2,if=3Dnone -device ahci,id=3Dahci
-device ide-drive,drive=3Ddisk,bus=3Dahci.0 -cdrom
./images/en_windows_7_ultimate_x86_dvd_x15-65921.iso  -monitor stdio
-cpu kvm64 -snapshot

and windows 7 does not boot.
This happens starting from this commit:

commit f68ec8379e88502b4841a110c070e9b118d3151c
Author: Andreas F=E4rber <afaerber@suse.de>
Date:   Wed Jun 5 15:17:57 2013 +0200

    ide: Set BSY bit during FLUSH
   =20
    The implementation of the ATA FLUSH command invokes a flush at the bl=
ock
    layer, which may on raw files on POSIX entail a synchronous fdatasync=
().
    This may in some cases take so long that the SLES 11 SP1 guest driver
    reports I/O errors and filesystems get corrupted or remounted read-on=
ly.
   =20
    Avoid this by setting BUSY_STAT, so that the guest is made aware we a=
re
    in the middle of an operation and no ATA commands are attempted to be
    processed concurrently.
   =20
    Addresses BNC#637297.
   =20
    Suggested-by: Gonglei (Arei) <arei.gonglei@huawei.com>
    Signed-off-by: Andreas F=E4rber <afaerber@suse.de>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


guest starts booting but never completes boot - it just keeps flashing
the flag image.  Boots fine with previous commit:
commit c27d565604038c1572b16dd1cd06e277e6ef02e2

However, reverting f68ec8379e88502b4841a110c070e9b118d3151c on
current master still has the hang on boot
behaviour - possibly a separate issue, I'll have to redo the bisect
to find out.

--=20
MST