From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uws8j-0001ED-UW for qemu-devel@nongnu.org; Wed, 10 Jul 2013 07:00:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uws8b-0005TX-U2 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 07:00:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uws8b-0005TL-L2 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 07:00:45 -0400 Date: Wed, 10 Jul 2013 19:00:20 +0800 From: Fam Zheng Message-ID: <20130710110020.GF18465@T430s.nay.redhat.com> References: <1373268366-14508-1-git-send-email-cngesaint@gmail.com> <1373268366-14508-6-git-send-email-cngesaint@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373268366-14508-6-git-send-email-cngesaint@gmail.com> Subject: Re: [Qemu-devel] [PATCH V2 5/5] Add infinite loop check in drive_init() Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xu Wang Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com On Mon, 07/08 03:26, Xu Wang wrote: > Signed-off-by: Xu Wang > --- > blockdev.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/blockdev.c b/blockdev.c > index 5975dde..0178764 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -695,6 +695,11 @@ DriveInfo *drive_init(QemuOpts *all_opts, BlockInterfaceType block_default_type) > error_report("warning: disabling copy_on_read on readonly drive"); > } > > + /* Add backing file loop check */ > + if (bdrv_backing_file_loop_check(file, NULL, true, NULL, NULL)) { You can pass drv->format_name as second parameter. > + goto err; > + } > + > ret = bdrv_open(dinfo->bdrv, file, bs_opts, bdrv_flags, drv); > bs_opts = NULL; > > -- > 1.8.1.4 > > -- Fam