From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwsj3-0007T1-Qu for qemu-devel@nongnu.org; Wed, 10 Jul 2013 07:38:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uwsj2-00017V-Fn for qemu-devel@nongnu.org; Wed, 10 Jul 2013 07:38:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwsaM-00065O-9o for qemu-devel@nongnu.org; Wed, 10 Jul 2013 07:29:26 -0400 Date: Wed, 10 Jul 2013 13:29:16 +0200 From: Kevin Wolf Message-ID: <20130710112916.GJ3898@dhcp-200-207.str.redhat.com> References: <1372338695-411-1-git-send-email-pl@kamp.de> <1372338695-411-10-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372338695-411-10-git-send-email-pl@kamp.de> Subject: Re: [Qemu-devel] [PATCHv2 09/11] iscsi: factor out sector conversions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: pbonzini@redhat.com, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben: > Signed-off-by: Peter Lieven > --- > block/iscsi.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) A bit confusing that you add only one function (because the other one is already there), but convert both directions. Looks correct, though. Reviewed-by: Kevin Wolf