From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwseB-0004Kd-Jm for qemu-devel@nongnu.org; Wed, 10 Jul 2013 07:33:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uwse8-0007eU-OD for qemu-devel@nongnu.org; Wed, 10 Jul 2013 07:33:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwse8-0007eA-Gf for qemu-devel@nongnu.org; Wed, 10 Jul 2013 07:33:20 -0400 Date: Wed, 10 Jul 2013 13:33:13 +0200 From: Kevin Wolf Message-ID: <20130710113313.GK3898@dhcp-200-207.str.redhat.com> References: <1372338695-411-1-git-send-email-pl@kamp.de> <1372338695-411-11-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372338695-411-11-git-send-email-pl@kamp.de> Subject: Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: pbonzini@redhat.com, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben: > if the target does not support UNMAP or the request > is too big silently ignore the discard request. > > Signed-off-by: Peter Lieven Why not loop for the "too big" case? You can probably use the same logic for unmapping the whole device in .bdrv_create and here. Kevin