From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxGSb-0006Zt-Nd for qemu-devel@nongnu.org; Thu, 11 Jul 2013 08:59:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxGSY-0002Ih-PX for qemu-devel@nongnu.org; Thu, 11 Jul 2013 08:59:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxGSY-0002IO-Ht for qemu-devel@nongnu.org; Thu, 11 Jul 2013 08:58:58 -0400 Date: Thu, 11 Jul 2013 16:00:07 +0300 From: "Michael S. Tsirkin" Message-ID: <20130711130007.GA3794@redhat.com> References: <20130708101259.GA16074@redhat.com> <871u78eavc.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871u78eavc.fsf@rustcorp.com.au> Subject: Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rusty Russell Cc: Cong Wang , qemu-devel@nongnu.org, netdev@vger.kernel.org, Jason Wang , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Dave Jones , Amos Kong , "David S. Miller" On Tue, Jul 09, 2013 at 11:46:23AM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > For small packets we can simplify xmit processing > > by linearizing buffers with the header: > > most packets seem to have enough head room > > we can use for this purpose. > > Since existing hypervisors require that header > > is the first s/g element, we need a feature bit > > for this. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Note: this needs to be applied on top of patch > > defining VIRTIO_F_ANY_LAYOUT - bit to be > > selected by Rusty. > > > > The following patch should work for any definition of > > VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing. > > Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT > > and squeeze this patch into 3.11? > > Sorry, it's too late. > > First, I've been a bit lax in sending patches via DaveM, and this is > definitely his territory (ie. more net than virtio). > > Secondly, it needs baking and testing time. > > Cheers, > Rusty. Okay. But we can already commit the qemu change, right? Also, can you submit the spec update please?