From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxMCj-0000ju-0G for qemu-devel@nongnu.org; Thu, 11 Jul 2013 15:07:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxMCc-0004Jk-KI for qemu-devel@nongnu.org; Thu, 11 Jul 2013 15:07:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxMCc-0004JT-C3 for qemu-devel@nongnu.org; Thu, 11 Jul 2013 15:06:54 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6BJ6r0u005128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Jul 2013 15:06:53 -0400 Date: Thu, 11 Jul 2013 22:08:07 +0300 From: "Michael S. Tsirkin" Message-ID: <20130711190807.GA25484@redhat.com> References: <1373552895-17349-1-git-send-email-akong@redhat.com> <51DEFF08.6060308@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51DEFF08.6060308@redhat.com> Subject: Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Amos Kong , qemu-devel@nongnu.org, armbru@redhat.com On Thu, Jul 11, 2013 at 12:52:56PM -0600, Eric Blake wrote: > On 07/11/2013 08:28 AM, Amos Kong wrote: > > Markus added some comments on old patchset, this patch contains > > some additional fixes, it's based on MST's PCI tree. > > > > * Fix typos (missed 1.6, NIC) > > * Don't initialize list point at its declaration > > * Always notify QMP client if mactable is changed > > * Returns NULL list if no net client supports rx-filter querying. > > > > BTW, we can also use e1000 with macvtap device, so we can implement > > a query_rx_filter function for e1000 in future. > > > > Signed-off-by: Amos Kong > > --- > > hw/net/virtio-net.c | 24 ++++++++++++++---------- > > net/net.c | 19 ++++++++++--------- > > qapi-schema.json | 11 ++++++----- > > qmp-commands.hx | 10 +++++----- > > 4 files changed, 35 insertions(+), 29 deletions(-) > > Reviewed-by: Eric Blake > > > @@ -3724,13 +3724,14 @@ > > # > > # @all: receive all assigned packets > > # > > +# Since: 1.6 > > ## > > { 'enum': 'RxState', 'data': [ 'normal', 'none', 'all' ] } > > I don't see RxState in the latest qemu.git (c170a23c); is it worth > trying to squash this in place to the pull request of the earlier > series, instead of as a followup patch? > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > It's easy for me to squash when I apply. Marcus - you were the second persons with comments here, are you happy with follow-up patches or do you prefer a full repost? -- MST