From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyF8O-0006ss-0y for qemu-devel@nongnu.org; Sun, 14 Jul 2013 01:46:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyF8L-0001LO-KX for qemu-devel@nongnu.org; Sun, 14 Jul 2013 01:46:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyF8L-0001LF-Cv for qemu-devel@nongnu.org; Sun, 14 Jul 2013 01:46:09 -0400 Date: Sun, 14 Jul 2013 08:47:19 +0300 From: "Michael S. Tsirkin" Message-ID: <20130714054719.GA15401@redhat.com> References: <52ef8c94b2e3af11ea918b2c84756d81a61db15f.1372234719.git.hutao@cn.fujitsu.com> <20130710101003.GA10203@redhat.com> <20130711071339.032864df@nial.usersys.redhat.com> <20130711084901.GA22937@redhat.com> <20130712013328.GD26557@G08FNSTD100614.fnst.cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130712013328.GD26557@G08FNSTD100614.fnst.cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v5 10/14] pc: Add dimm paravirt SRAT info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Vasilis Liaskovitis , Igor Mammedov , qemu-devel@nongnu.org On Fri, Jul 12, 2013 at 09:33:28AM +0800, Hu Tao wrote: > On Thu, Jul 11, 2013 at 11:49:01AM +0300, Michael S. Tsirkin wrote: > > On Thu, Jul 11, 2013 at 07:13:39AM +0200, Igor Mammedov wrote: > > > On Wed, 10 Jul 2013 13:10:03 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed, Jun 26, 2013 at 05:13:33PM +0800, Hu Tao wrote: > > > > > The numa_fw_cfg paravirt interface is extended to include SRAT information for > > > > > all hotplug-able dimms. There are 3 words for each hotplug-able memory slot, > > > > > denoting start address, size and node proximity. The new info is appended after > > > > > existing numa info, so that the fw_cfg layout does not break. This information > > > > > is used by Seabios to build hotplug memory device objects at runtime. > > > > > nb_numa_nodes is set to 1 by default (not 0), so that we always pass srat info > > > > > to SeaBIOS. > > > > > > > > > > v3->v4: numa_fw_cfg needs to be initalized after memory controller sets up dimm > > > > > ranges. Make changes for pc_piix and pc_q35 to set numa_fw_cfg after i440fx > > > > > initialization. > > > > > > > > > > v2->v3: setting nb_numa_nodes to 1 is not needed > > > > > > > > > > v1->v2: > > > > > Dimm SRAT info (#dimms) is appended at end of existing numa fw_cfg in order not > > > > > to break existing layout > > > > > Documentation of the new fwcfg layout is included in docs/specs/fwcfg.txt > > > > > > > > > > Signed-off-by: Vasilis Liaskovitis > > > > > Signed-off-by: Hu Tao > > > > > > > > Please do not add any more fwcfg interfaces - generating > > > > ACPI in qemu removes the need for it. > > > > > > > > So please rebase on top of that work and generate the appropriate ACPI > > > > tables directly. > > > > > > > > You can find the latest code gnerating ACPI from qemu here: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi > > > > > > will it work with upstream Seabios or custom tree is required for it as well? > > > > Yes. > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/seabios.git acpi > > This means I must rebase both qemu and seabios patches on top of your > acpi tree. I hope there won't be too much conflicts:) Shouldn't be hard, if there's a problem pls tell me and I'll try to help.