From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/3] Fail migration on bdrv_flush_all() error
Date: Mon, 15 Jul 2013 15:00:12 +0800 [thread overview]
Message-ID: <20130715070012.GA18111@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1373025833-22859-1-git-send-email-kwolf@redhat.com>
On Fri, Jul 05, 2013 at 02:03:50PM +0200, Kevin Wolf wrote:
> If bdrv_flush_all() returns an error, there is an inconsistency in the
> view of an image file between the source and the destination host.
> Completing the migration would lead to corruption. Better abort
> migration in this case.
>
> Kevin Wolf (3):
> block: Add return value for bdrv_flush_all()
> cpus: Add return value for vm_stop()
> migration: Fail migration on bdrv_flush_all() error
>
> block.c | 10 ++++++++--
> cpus.c | 20 +++++++++++++-------
> include/block/block.h | 2 +-
> include/sysemu/sysemu.h | 4 ++--
> migration.c | 17 ++++++++++++++---
> stubs/vm-stop.c | 2 +-
> 6 files changed, 39 insertions(+), 16 deletions(-)
Modulo Paolo's comments.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
prev parent reply other threads:[~2013-07-15 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 12:03 [Qemu-devel] [PATCH 0/3] Fail migration on bdrv_flush_all() error Kevin Wolf
2013-07-05 12:03 ` [Qemu-devel] [PATCH 1/3] block: Add return value for bdrv_flush_all() Kevin Wolf
2013-07-05 12:03 ` [Qemu-devel] [PATCH 2/3] cpus: Add return value for vm_stop() Kevin Wolf
2013-07-05 12:40 ` Paolo Bonzini
2013-07-05 12:03 ` [Qemu-devel] [PATCH 3/3] migration: Fail migration on bdrv_flush_all() error Kevin Wolf
2013-07-15 7:00 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715070012.GA18111@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).