From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32810)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Uyclk-0005oH-MD
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 03:00:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Uyclj-0006OK-DJ
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 03:00:24 -0400
Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:48239)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Uyclj-0006N5-7f
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 03:00:23 -0400
Received: by mail-we0-f172.google.com with SMTP id q56so9735847wes.17
	for <qemu-devel@nongnu.org>; Mon, 15 Jul 2013 00:00:22 -0700 (PDT)
Date: Mon, 15 Jul 2013 15:00:12 +0800
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130715070012.GA18111@stefanha-thinkpad.redhat.com>
References: <1373025833-22859-1-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1373025833-22859-1-git-send-email-kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] Fail migration on bdrv_flush_all()
	error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, quintela@redhat.com

On Fri, Jul 05, 2013 at 02:03:50PM +0200, Kevin Wolf wrote:
> If bdrv_flush_all() returns an error, there is an inconsistency in the
> view of an image file between the source and the destination host.
> Completing the migration would lead to corruption. Better abort
> migration in this case.
> 
> Kevin Wolf (3):
>   block: Add return value for bdrv_flush_all()
>   cpus: Add return value for vm_stop()
>   migration: Fail migration on bdrv_flush_all() error
> 
>  block.c                 | 10 ++++++++--
>  cpus.c                  | 20 +++++++++++++-------
>  include/block/block.h   |  2 +-
>  include/sysemu/sysemu.h |  4 ++--
>  migration.c             | 17 ++++++++++++++---
>  stubs/vm-stop.c         |  2 +-
>  6 files changed, 39 insertions(+), 16 deletions(-)

Modulo Paolo's comments.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>