qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: famz@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
	qemu-stable@nongnu.org, alex.williamson@redhat.com,
	afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] ahci: Fix FLUSH command
Date: Mon, 15 Jul 2013 17:47:22 +0800	[thread overview]
Message-ID: <20130715094722.GA5512@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1373880871-28521-1-git-send-email-kwolf@redhat.com>

On Mon, Jul 15, 2013 at 11:34:31AM +0200, Kevin Wolf wrote:
> AHCI couldn't cope with asynchronous commands that aren't doing DMA, it
> simply wouldn't complete them. Due to the bug fixed in commit f68ec837,
> FLUSH commands would seem to have completed immediately even if they
> were still running on the host. After the commit, they would simply hang
> and never unset the BSY bit, rendering AHCI unusable on any OS sending
> flushes.
> 
> This patch adds another callback for the completion of asynchronous
> commands. This is what AHCI really wants to use for its command
> completion logic rather than an DMA completion callback.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  hw/ide/ahci.c     | 8 +++++++-
>  hw/ide/core.c     | 9 +++++++++
>  hw/ide/internal.h | 1 +
>  3 files changed, 17 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

  reply	other threads:[~2013-07-15  9:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15  9:34 [Qemu-devel] [PATCH] ahci: Fix FLUSH command Kevin Wolf
2013-07-15  9:47 ` Stefan Hajnoczi [this message]
2013-07-15 21:26 ` Alex Williamson
2013-07-16  6:50 ` Fam Zheng
2013-07-16 12:30 ` Andreas Färber
2013-07-16 12:45   ` Kevin Wolf
2013-07-16 12:39 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130715094722.GA5512@stefanha-thinkpad.redhat.com \
    --to=stefanha@redhat.com \
    --cc=afaerber@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).