From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfNV-0006nX-Ot for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:47:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyfNS-0004WF-0j for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:47:33 -0400 Date: Mon, 15 Jul 2013 17:47:22 +0800 From: Stefan Hajnoczi Message-ID: <20130715094722.GA5512@stefanha-thinkpad.redhat.com> References: <1373880871-28521-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373880871-28521-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] ahci: Fix FLUSH command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: famz@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org, alex.williamson@redhat.com, afaerber@suse.de On Mon, Jul 15, 2013 at 11:34:31AM +0200, Kevin Wolf wrote: > AHCI couldn't cope with asynchronous commands that aren't doing DMA, it > simply wouldn't complete them. Due to the bug fixed in commit f68ec837, > FLUSH commands would seem to have completed immediately even if they > were still running on the host. After the commit, they would simply hang > and never unset the BSY bit, rendering AHCI unusable on any OS sending > flushes. > > This patch adds another callback for the completion of asynchronous > commands. This is what AHCI really wants to use for its command > completion logic rather than an DMA completion callback. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Kevin Wolf > --- > hw/ide/ahci.c | 8 +++++++- > hw/ide/core.c | 9 +++++++++ > hw/ide/internal.h | 1 + > 3 files changed, 17 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi