From: Stefan Hajnoczi <stefanha@gmail.com>
To: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com,
zhangxh@cn.fujitsu.com, anderson@redhat.com,
kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v5 2/9] dump: Add API to write header of flatten format
Date: Tue, 16 Jul 2013 10:06:44 +0800 [thread overview]
Message-ID: <20130716020644.GA32278@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1373355014-14846-3-git-send-email-qiaonuohan@cn.fujitsu.com>
On Tue, Jul 09, 2013 at 03:30:07PM +0800, Qiao Nuohan wrote:
> +static int write_start_flat_header(int fd)
> +{
> + char buf[MAX_SIZE_MDF_HEADER];
> + MakedumpfileHeader mh;
Why is buf[] necessary? You can write mh directly.
next prev parent reply other threads:[~2013-07-16 2:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 7:30 [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format Qiao Nuohan
2013-07-09 7:30 ` [Qemu-devel] [PATCH v5 1/9] dump: Add argument to write_elfxx_notes Qiao Nuohan
2013-07-09 7:30 ` [Qemu-devel] [PATCH v5 2/9] dump: Add API to write header of flatten format Qiao Nuohan
2013-07-16 2:06 ` Stefan Hajnoczi [this message]
2013-07-16 3:50 ` Qiao Nuohan
2013-07-09 7:30 ` [Qemu-devel] [PATCH v5 3/9] dump: Add API to write vmcore Qiao Nuohan
2013-07-09 7:30 ` [Qemu-devel] [PATCH v5 4/9] dump: Add API to write elf notes to buffer Qiao Nuohan
2013-07-09 7:30 ` [Qemu-devel] [PATCH v5 5/9] dump: add API to write dump header Qiao Nuohan
2013-07-16 2:18 ` Stefan Hajnoczi
2013-07-09 7:30 ` [Qemu-devel] [PATCH v5 6/9] dump: Add API to write dump_bitmap Qiao Nuohan
2013-07-16 2:25 ` Stefan Hajnoczi
2013-07-09 7:30 ` [Qemu-devel] [PATCH v5 7/9] dump: Add APIs to operate DataCache Qiao Nuohan
2013-07-09 7:30 ` [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages Qiao Nuohan
2013-07-16 2:43 ` Stefan Hajnoczi
2013-07-16 3:40 ` Qiao Nuohan
2013-07-16 16:28 ` Eric Blake
2013-07-09 7:30 ` [Qemu-devel] [PATCH v5 9/9] dump: Make kdump-compressed format available for 'dump-guest-memory' Qiao Nuohan
2013-07-09 7:36 ` [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format Qiao Nuohan
2013-07-15 9:56 ` Qiao Nuohan
2013-07-16 2:45 ` Stefan Hajnoczi
2013-07-31 9:26 ` Qiao Nuohan
2013-07-31 12:23 ` Laszlo Ersek
2013-07-31 13:10 ` Luiz Capitulino
2013-08-02 3:25 ` Qiao Nuohan
2013-08-02 3:41 ` Amos Kong
2013-08-02 3:43 ` Qiao Nuohan
2013-08-02 3:37 ` Qiao Nuohan
2013-12-13 2:07 ` Qiao Nuohan
2013-12-13 2:25 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716020644.GA32278@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=anderson@redhat.com \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qiaonuohan@cn.fujitsu.com \
--cc=zhangxh@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).