From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UyufI-0003Ev-4R
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 22:06:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UyufH-0007r2-Bl
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 22:06:56 -0400
Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:34314)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UyufH-0007qH-1n
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 22:06:55 -0400
Received: by mail-wi0-f180.google.com with SMTP id c10so106205wiw.13
	for <qemu-devel@nongnu.org>; Mon, 15 Jul 2013 19:06:54 -0700 (PDT)
Date: Tue, 16 Jul 2013 10:06:44 +0800
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130716020644.GA32278@stefanha-thinkpad.redhat.com>
References: <1373355014-14846-1-git-send-email-qiaonuohan@cn.fujitsu.com>
	<1373355014-14846-3-git-send-email-qiaonuohan@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1373355014-14846-3-git-send-email-qiaonuohan@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v5 2/9] dump: Add API to write header of
	flatten format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com, zhangxh@cn.fujitsu.com, anderson@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de

On Tue, Jul 09, 2013 at 03:30:07PM +0800, Qiao Nuohan wrote:
> +static int write_start_flat_header(int fd)
> +{
> +    char buf[MAX_SIZE_MDF_HEADER];
> +    MakedumpfileHeader mh;

Why is buf[] necessary?  You can write mh directly.