From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Don't parse protocol from file.filename
Date: Tue, 16 Jul 2013 13:58:55 +0800 [thread overview]
Message-ID: <20130716055855.GC10106@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1373464273-7934-1-git-send-email-kwolf@redhat.com>
On Wed, Jul 10, 2013 at 03:51:13PM +0200, Kevin Wolf wrote:
> One of the major reasons for doing something new for -blockdev and
> blockdev-add was that the old block layer code parses filenames instead
> of just taking them literally. So we should really leave it untouched
> when it's passing using the new interfaces (like -drive
> file.filename=...).
>
> This allows opening relative file names that contain a colon.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 17 ++++++++++++-----
> block/sheepdog.c | 2 +-
> include/block/block.h | 3 ++-
> qemu-img.c | 4 ++--
> tests/qemu-iotests/051 | 12 ++++++++++++
> tests/qemu-iotests/051.out | 14 ++++++++++++++
> 6 files changed, 43 insertions(+), 9 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2013-07-16 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 13:51 [Qemu-devel] [PATCH] block: Don't parse protocol from file.filename Kevin Wolf
2013-07-10 17:09 ` Eric Blake
2013-07-11 7:19 ` Kevin Wolf
2013-07-16 5:58 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716055855.GC10106@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).