From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyyHx-00069y-UN for qemu-devel@nongnu.org; Tue, 16 Jul 2013 01:59:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyyHx-0003MQ-3M for qemu-devel@nongnu.org; Tue, 16 Jul 2013 01:59:05 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:41609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyyHw-0003MI-TL for qemu-devel@nongnu.org; Tue, 16 Jul 2013 01:59:05 -0400 Received: by mail-wi0-f169.google.com with SMTP id c10so3713997wiw.4 for ; Mon, 15 Jul 2013 22:59:03 -0700 (PDT) Date: Tue, 16 Jul 2013 13:58:55 +0800 From: Stefan Hajnoczi Message-ID: <20130716055855.GC10106@stefanha-thinkpad.redhat.com> References: <1373464273-7934-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373464273-7934-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Don't parse protocol from file.filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Wed, Jul 10, 2013 at 03:51:13PM +0200, Kevin Wolf wrote: > One of the major reasons for doing something new for -blockdev and > blockdev-add was that the old block layer code parses filenames instead > of just taking them literally. So we should really leave it untouched > when it's passing using the new interfaces (like -drive > file.filename=...). > > This allows opening relative file names that contain a colon. > > Signed-off-by: Kevin Wolf > --- > block.c | 17 ++++++++++++----- > block/sheepdog.c | 2 +- > include/block/block.h | 3 ++- > qemu-img.c | 4 ++-- > tests/qemu-iotests/051 | 12 ++++++++++++ > tests/qemu-iotests/051.out | 14 ++++++++++++++ > 6 files changed, 43 insertions(+), 9 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan