From: Stefan Hajnoczi <stefanha@gmail.com>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anand Avati <aavati@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver
Date: Tue, 16 Jul 2013 14:02:38 +0800 [thread overview]
Message-ID: <20130716060238.GA29714@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20130712065854.GJ32532@in.ibm.com>
On Fri, Jul 12, 2013 at 12:28:54PM +0530, Bharata B Rao wrote:
> gluster: Use pkg-config to configure GlusterFS block driver
The commit message is duplicated in the commit description.
> Use pkg-config to determine the version and library dependency
> for GlusterFS block driver.
>
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> ---
> configure | 20 +++++++-------------
> 1 file changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/configure b/configure
> index cb0f870..76adcb1 100755
> --- a/configure
> +++ b/configure
> @@ -2566,23 +2566,17 @@ fi
> ##########################################
> # glusterfs probe
> if test "$glusterfs" != "no" ; then
> - cat > $TMPC <<EOF
> -#include <glusterfs/api/glfs.h>
> -int main(void) {
> - (void) glfs_new("volume");
> - return 0;
> -}
> -EOF
> - glusterfs_libs="-lgfapi -lgfrpc -lgfxdr"
> - if compile_prog "" "$glusterfs_libs" ; then
> - glusterfs=yes
> - libs_tools="$glusterfs_libs $libs_tools"
> - libs_softmmu="$glusterfs_libs $libs_softmmu"
> + if $pkg_config --atleast-version=3 glusterfs-api >/dev/null 2>&1; then
gfapi was added in Gluster 3.4. Is --atleast-version=3 sufficient?
next prev parent reply other threads:[~2013-07-16 6:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 6:56 [Qemu-devel] [RFC PATCH v1 0/3] pkg-config and discard support for gluster driver Bharata B Rao
2013-07-12 6:58 ` [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver Bharata B Rao
2013-07-16 6:02 ` Stefan Hajnoczi [this message]
2013-07-16 6:04 ` Anand Avati
2013-07-16 8:25 ` Kevin Wolf
2013-07-16 11:34 ` Bharata B Rao
2013-07-23 11:57 ` Daniel P. Berrange
2013-07-23 12:02 ` Anand Avati
2013-07-23 12:03 ` Daniel P. Berrange
2013-07-23 12:07 ` Kaleb KEITHLEY
2013-07-23 12:14 ` Daniel P. Berrange
2013-07-12 7:00 ` [Qemu-devel] [RFC PATCH v1 2/2] gluster: Add discard support for " Bharata B Rao
2013-07-16 6:05 ` Stefan Hajnoczi
2013-07-16 8:29 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716060238.GA29714@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=aavati@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).