From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyzPR-0002VW-G4 for qemu-devel@nongnu.org; Tue, 16 Jul 2013 03:10:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyzPQ-0002nU-9z for qemu-devel@nongnu.org; Tue, 16 Jul 2013 03:10:53 -0400 Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:53069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyzPQ-0002nK-1j for qemu-devel@nongnu.org; Tue, 16 Jul 2013 03:10:52 -0400 Received: by mail-we0-f179.google.com with SMTP id w59so260360wes.38 for ; Tue, 16 Jul 2013 00:10:51 -0700 (PDT) Date: Tue, 16 Jul 2013 15:10:41 +0800 From: Stefan Hajnoczi Message-ID: <20130716071041.GA30636@stefanha-thinkpad.redhat.com> References: <1373903207-27085-1-git-send-email-cornelia.huck@de.ibm.com> <874nbvsr3d.fsf@codemonkey.ws> <51E42E4B.1090604@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51E42E4B.1090604@redhat.com> Subject: Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Anthony Liguori , qemu-devel , Blue Swirl , Stefan Hajnoczi , Cornelia Huck , =?iso-8859-1?Q?Aur=E9lien?= Jarno On Mon, Jul 15, 2013 at 07:15:55PM +0200, Paolo Bonzini wrote: > Il 15/07/2013 18:52, Anthony Liguori ha scritto: > > Cornelia Huck writes: > > > >> The following changes since commit c3cb8e77804313e1be99b5f28a34a346736707a5: > >> > >> ioport: remove LITTLE_ENDIAN mark for portio (2013-07-12 14:37:47 -0500) > >> > >> are available in the git repository at: > >> > >> git://github.com/cohuck/qemu virtio-ccw-upstr > >> > >> for you to fetch changes up to bf72d89f0a8fb27a6bfde1a689690fd577227762: > >> > >> virtio-ccw: Enable x-data-plane for virtio-ccw-blk (2013-07-15 > >> 17:39:04 +0200) > > > > This is v1? This was just posted on Thursday? That's a bit too quick > > for a pull request. > > > > I've seen no review from Stefan or Paolo and I would think that given > > the work that's been done already, it would be counterproductive to > > enable x-data-plane for another backend. > > > > Paolo/Stefan, what do you guys think? > > Considering what the patch looks like, I don't think it's a huge > problem... In fact, perhaps x-data-plane could be even added to > DEFINE_VIRTIO_BLK_PROPERTIES. This would make it clear that support for > non-ioeventfd hosts (including TCG) is one of the things to do to make > data plane the default. I agree. Since this patch is so minimal it will not add extra work as we reintegrate dataplane into core QEMU. Acked-by: Stefan Hajnoczi