From: Amos Kong <akong@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature
Date: Tue, 16 Jul 2013 18:52:22 +0800 [thread overview]
Message-ID: <20130716105222.GA743@amosk.info> (raw)
In-Reply-To: <20130715182828.GA8073@redhat.com>
On Mon, Jul 15, 2013 at 09:28:28PM +0300, Michael S. Tsirkin wrote:
> On Thu, Jul 11, 2013 at 10:28:15PM +0800, Amos Kong wrote:
> > Markus added some comments on old patchset, this patch contains
> > some additional fixes, it's based on MST's PCI tree.
> >
> > * Fix typos (missed 1.6, NIC)
> > * Don't initialize list point at its declaration
> > * Always notify QMP client if mactable is changed
> > * Returns NULL list if no net client supports rx-filter querying.
> >
> > BTW, we can also use e1000 with macvtap device, so we can implement
> > a query_rx_filter function for e1000 in future.
> >
> > Signed-off-by: Amos Kong <akong@redhat.com>
>
> I applied this and folded into your previous
> patch. Pushed on my pci branch.
> Amos, could you please verify (and test)
> that the result is correct?
I tested your latest pci branch, it's correct.
I didn't find other issue in my test.
Thanks, Amos
> Thanks,
prev parent reply other threads:[~2013-07-16 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 14:28 [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature Amos Kong
2013-07-11 18:52 ` Eric Blake
2013-07-11 19:08 ` Michael S. Tsirkin
2013-07-15 16:57 ` Markus Armbruster
2013-07-15 16:56 ` Markus Armbruster
2013-07-15 18:28 ` Michael S. Tsirkin
2013-07-16 10:52 ` Amos Kong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716105222.GA743@amosk.info \
--to=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).