From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1Uz2rq-0002I4-KS
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 06:52:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1Uz2rp-00041D-O0
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 06:52:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19553)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1Uz2rp-000415-Fl
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 06:52:25 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6GAqOst003413
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 16 Jul 2013 06:52:24 -0400
Date: Tue, 16 Jul 2013 18:52:22 +0800
From: Amos Kong <akong@redhat.com>
Message-ID: <20130716105222.GA743@amosk.info>
References: <1373552895-17349-1-git-send-email-akong@redhat.com>
	<20130715182828.GA8073@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130715182828.GA8073@redhat.com>
Subject: Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for
	mac-programming feature
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com

On Mon, Jul 15, 2013 at 09:28:28PM +0300, Michael S. Tsirkin wrote:
> On Thu, Jul 11, 2013 at 10:28:15PM +0800, Amos Kong wrote:
> > Markus added some comments on old patchset, this patch contains
> > some additional fixes, it's based on MST's PCI tree.
> > 
> > * Fix typos (missed 1.6, NIC)
> > * Don't initialize list point at its declaration
> > * Always notify QMP client if mactable is changed
> > * Returns NULL list if no net client supports rx-filter querying.
> > 
> > BTW, we can also use e1000 with macvtap device, so we can implement
> > a query_rx_filter function for e1000 in future.
> > 
> > Signed-off-by: Amos Kong <akong@redhat.com>
> 
> I applied this and folded into your previous
> patch. Pushed on my pci branch.
> Amos, could you please verify (and test)
> that the result is correct?

I tested your latest pci branch, it's correct.
I didn't find other issue in my test.

Thanks, Amos
 
> Thanks,