From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz11s-0006uX-Va for qemu-devel@nongnu.org; Tue, 16 Jul 2013 04:54:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz11r-00045D-Ua for qemu-devel@nongnu.org; Tue, 16 Jul 2013 04:54:40 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:49637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz11r-000457-MM for qemu-devel@nongnu.org; Tue, 16 Jul 2013 04:54:39 -0400 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Jul 2013 09:46:28 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8D74B1B08070 for ; Tue, 16 Jul 2013 09:54:36 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6G8sPui44957938 for ; Tue, 16 Jul 2013 08:54:25 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r6G8sZSn002299 for ; Tue, 16 Jul 2013 02:54:36 -0600 Date: Tue, 16 Jul 2013 10:54:32 +0200 From: Cornelia Huck Message-ID: <20130716105432.0415d563@gondolin> In-Reply-To: <20130716071041.GA30636@stefanha-thinkpad.redhat.com> References: <1373903207-27085-1-git-send-email-cornelia.huck@de.ibm.com> <874nbvsr3d.fsf@codemonkey.ws> <51E42E4B.1090604@redhat.com> <20130716071041.GA30636@stefanha-thinkpad.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , qemu-devel , Blue Swirl , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?B?QXVy?= =?UTF-8?B?w6lsaWVu?= Jarno On Tue, 16 Jul 2013 15:10:41 +0800 Stefan Hajnoczi wrote: > On Mon, Jul 15, 2013 at 07:15:55PM +0200, Paolo Bonzini wrote: > > Il 15/07/2013 18:52, Anthony Liguori ha scritto: > > > Cornelia Huck writes: > > > > > >> The following changes since commit c3cb8e77804313e1be99b5f28a34a346736707a5: > > >> > > >> ioport: remove LITTLE_ENDIAN mark for portio (2013-07-12 14:37:47 -0500) > > >> > > >> are available in the git repository at: > > >> > > >> git://github.com/cohuck/qemu virtio-ccw-upstr > > >> > > >> for you to fetch changes up to bf72d89f0a8fb27a6bfde1a689690fd577227762: > > >> > > >> virtio-ccw: Enable x-data-plane for virtio-ccw-blk (2013-07-15 > > >> 17:39:04 +0200) > > > > > > This is v1? This was just posted on Thursday? That's a bit too quick > > > for a pull request. > > > > > > I've seen no review from Stefan or Paolo and I would think that given > > > the work that's been done already, it would be counterproductive to > > > enable x-data-plane for another backend. > > > > > > Paolo/Stefan, what do you guys think? > > > > Considering what the patch looks like, I don't think it's a huge > > problem... In fact, perhaps x-data-plane could be even added to > > DEFINE_VIRTIO_BLK_PROPERTIES. This would make it clear that support for > > non-ioeventfd hosts (including TCG) is one of the things to do to make > > data plane the default. > > I agree. Since this patch is so minimal it will not add extra work as > we reintegrate dataplane into core QEMU. > > Acked-by: Stefan Hajnoczi > Thank you. Any further guidelines on when to ask for acks from you guys? The mode I've been operating in is mostly "if virtio-pci provides this feature, it shouldn't be half bad and we want it in virtio-ccw as well in order to keep things consistent and get more test coverage". (dataplane has been enabled in our internal testing for some time now, I just had asked Dominik to re-do his patch with a proper description as we had some code churn in our internal repository.)