From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1Uz3Ur-0005uA-DW
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 07:32:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1Uz3Un-0001nf-Pc
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 07:32:45 -0400
Received: from e28smtp03.in.ibm.com ([122.248.162.3]:33091)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1Uz3Un-0001k2-4V
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 07:32:41 -0400
Received: from /spool/local
	by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <bharata@linux.vnet.ibm.com>;
	Tue, 16 Jul 2013 16:55:38 +0530
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by d28dlp01.in.ibm.com (Postfix) with ESMTP id 01872E0053
	for <qemu-devel@nongnu.org>; Tue, 16 Jul 2013 17:02:05 +0530 (IST)
Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r6GBW8k434537488
	for <qemu-devel@nongnu.org>; Tue, 16 Jul 2013 17:02:08 +0530
Received: from d28av05.in.ibm.com (loopback [127.0.0.1])
	by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r6GBW99T006143
	for <qemu-devel@nongnu.org>; Tue, 16 Jul 2013 21:32:11 +1000
Date: Tue, 16 Jul 2013 17:04:45 +0530
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Message-ID: <20130716113445.GF4823@in.ibm.com>
References: <20130712065614.GI32532@in.ibm.com>
	<20130712065854.GJ32532@in.ibm.com>
	<20130716082529.GB2387@dhcp-200-207.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130716082529.GB2387@dhcp-200-207.str.redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to
 configure GlusterFS block driver
Reply-To: bharata@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Anand Avati <aavati@redhat.com>, qemu-devel@nongnu.org

On Tue, Jul 16, 2013 at 10:25:29AM +0200, Kevin Wolf wrote:
> > -  glusterfs_libs="-lgfapi -lgfrpc -lgfxdr"
> > -  if compile_prog "" "$glusterfs_libs" ; then
> > -    glusterfs=yes
> > -    libs_tools="$glusterfs_libs $libs_tools"
> > -    libs_softmmu="$glusterfs_libs $libs_softmmu"
> > +  if $pkg_config --atleast-version=3 glusterfs-api >/dev/null 2>&1; then
> > +    glusterfs="yes"
> > +    glusterfs_cflags=`$pkg_config --cflags glusterfs-api 2>/dev/null`
> > +    glusterfs_libs=`$pkg_config --libs glusterfs-api 2>/dev/null`
> > +    CFLAGS="$CFLAGS $glusterfs_cflags"
> > +    LIBS="$LIBS $glusterfs_libs"
> 
> Why do you switch from libs_tools/libs_softmmu to LIBS? If I understand
> it right, this means that you now link the library to linux-user targets
> as well, but I can't see how they need it.

Copied from some other backend and didn't realize that I ended up considering
linux-user target also. Will change this and send v2.

Regards,
Bharata.