From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzH2J-0000cN-UZ for qemu-devel@nongnu.org; Tue, 16 Jul 2013 22:00:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzH2J-0004CM-0U for qemu-devel@nongnu.org; Tue, 16 Jul 2013 22:00:11 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:48402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzH2I-0004Bm-RG for qemu-devel@nongnu.org; Tue, 16 Jul 2013 22:00:10 -0400 Received: by mail-wi0-f175.google.com with SMTP id m6so4834512wiv.2 for ; Tue, 16 Jul 2013 19:00:09 -0700 (PDT) Date: Wed, 17 Jul 2013 10:00:01 +0800 From: Stefan Hajnoczi Message-ID: <20130717020001.GA24502@stefanha-thinkpad.redhat.com> References: <51E5405C.6080108@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51E5405C.6080108@siemens.com> Subject: Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Paolo Bonzini , qemu-devel On Tue, Jul 16, 2013 at 02:45:16PM +0200, Jan Kiszka wrote: > This restore the behavior prior to b018ddf633 which accidentally changed > the return code to 0. Specifically guests probing for register existence > were affected by this. > > Signed-off-by: Jan Kiszka > --- > memory.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/memory.c b/memory.c > index 757e9a5..d19b61b 100644 > --- a/memory.c > +++ b/memory.c > @@ -859,7 +859,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr, > cpu_unassigned_access(ENV_GET_CPU(cpu_single_env), > addr, false, false, 0, size); > } > - return 0; > + return -1ULL; > } > > static void unassigned_mem_write(void *opaque, hwaddr addr, Fixes the IPMI timeout while booting RHEL 6.4 guests. Tested-by: Stefan Hajnoczi