Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

[Kevin Wolf <kwolf@redhat.com>]

Am 16.07.2013 um 18:55 hat Paolo Bonzini geschrieben:
> >> But I wouldn't introduce a
> >> new one-off concept (almost as much of a hack as idle BHs), I would
> >> rather reuse as much code as possible from QEMUTimer/QEMUClock.  I must
> >> admit I don't have a clear idea of how the API would look like.
> > 
> > So the reason I was trying to avoid using QEMUTimer stuff was that
> > bh's get called from aio_poll and it was not evident that all timers
> > would be safe to call from aio_poll.
> 
> It wouldn't.
> 
> > What do you think? In the end I thought the schedule_bh_at stuff
> > was simpler.
> 
> It is simpler, but I'm not sure it is the right API.  Of course, if
> Kevin and Stefan says it is, I have no problem with that.

Well, the one thing I'm pretty sure we need is an additional interface,
so that existing timers continue to run only from the main loop, and new
timers / timed BHs / whatever have the option to run in nested event
loops as well.

I don't really care what the thing is called as long as it does what is
needed. Timed BHs seemed to do that, so I agreed.

Kevin