From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UzMyZ-0000AN-DO
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 04:20:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UzMyV-0004JG-HV
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 04:20:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30557)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UzMyV-0004J4-8v
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 04:20:39 -0400
Date: Wed, 17 Jul 2013 10:20:30 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130717082030.GC2458@dhcp-200-207.str.redhat.com>
References: <1371738392-9594-1-git-send-email-benoit@irqsave.net>
	<1371738392-9594-2-git-send-email-benoit@irqsave.net>
	<20130702144224.GF9870@stefanha-thinkpad.redhat.com>
	<20130702212355.GB4985@irqsave.net>
	<20130703081235.GD16585@stefanha-thinkpad.muc.redhat.com>
	<20130703125327.GC5482@irqsave.net>
	<20130704071300.GA2584@stefanha-thinkpad.redhat.com>
	<20130704100128.GA5429@irqsave.net>
	<20130716224530.GB5102@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20130716224530.GB5102@irqsave.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 17.07.2013 um 00:45 hat Beno=EEt Canet geschrieben:
> > > Simple is good.  Even for deduplication alone, I think data integri=
ty is
> > > critical - otherwise we risk stale dedup metadata pointing to clust=
ers
> > > that are unallocated or do not contain the right data.  So the jour=
nal
> > > will probably need to follow techniques for commits/checksums.
> >
>=20
> I'll add checksums to the journal and clean the journal entry size mess=
 soon.
>=20
> For the transactional/commits aspect of the journal I think that we nee=
d Kevin's
> point of view on the subject.

Sorry, I was going to prepare a patch that does journalling for the
existing metadata, but once again other things stole my time. I'm still
planning to do that, though, and then we can compare whether your
requirements are fulfilled with it as well.

Kevin