From: Kevin Wolf <kwolf@redhat.com>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: wdongxu@cn.ibm.com, qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V17 8/9] qemu-option: make qemu_opts_del accept opts being NULL
Date: Wed, 17 Jul 2013 13:48:26 +0200 [thread overview]
Message-ID: <20130717114826.GH2458@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <CAGrFBsiGFW-vt2pC2AoV1RGSEV0km3oMXb5JVsc9B8b-2_DBMw@mail.gmail.com>
Am 17.07.2013 um 11:50 hat Dong Xu Wang geschrieben:
> Please ignore patch 8 and patch9, it won't work and I will re-send
> them seperately.
> Sorry for the inconvenience.
Seriously? We're at v17 and you're still sending code that is broken
enough that you recall it after half an hour? How much and what kind of
testing did you give the series after you made the latest changes?
I'm not planning to review anything that is likely to be broken anyway
because you rushed things.
Kevin
next prev parent reply other threads:[~2013-07-17 11:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 9:29 [Qemu-devel] [PATCH V17 0/9] replace QEMUOptionParameter with QemuOpts parser Dong Xu Wang
2013-07-17 9:29 ` [Qemu-devel] [PATCH V17 1/9] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print Dong Xu Wang
2013-07-17 9:29 ` [Qemu-devel] [PATCH V17 2/9] qemu-option: avoid duplication of default value in QemuOpts Dong Xu Wang
2013-07-17 9:29 ` [Qemu-devel] [PATCH V17 3/9] qemu-option: create four QemuOptsList related functions Dong Xu Wang
2013-07-17 9:29 ` [Qemu-devel] [PATCH V17 4/9] qemu-option: create some QemuOpts functons Dong Xu Wang
2013-07-17 9:29 ` [Qemu-devel] [PATCH V17 5/9] block: use QemuOpts support in block layer Dong Xu Wang
2013-07-17 9:48 ` Dong Xu Wang
2013-07-17 9:29 ` [Qemu-devel] [PATCH V17 6/9] qapi: query-command-line-options outputs def_value_str Dong Xu Wang
2013-07-17 9:29 ` [Qemu-devel] [PATCH V17 7/9] qemu-option: remove QEMUOptionParameter related functions and struct Dong Xu Wang
2013-07-17 9:29 ` [Qemu-devel] [PATCH V17 8/9] qemu-option: make qemu_opts_del accept opts being NULL Dong Xu Wang
2013-07-17 9:50 ` Dong Xu Wang
2013-07-17 11:48 ` Kevin Wolf [this message]
2013-07-17 9:29 ` [Qemu-devel] [PATCH V17 9/9] qemu-option: use qemu_opts_del without judging NULL Dong Xu Wang
2013-07-17 12:54 ` [Qemu-devel] [PATCH V17 0/9] replace QEMUOptionParameter with QemuOpts parser Eric Blake
2013-07-17 14:11 ` Dong Xu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717114826.GH2458@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wdongxu@cn.ibm.com \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).