qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: qzhang@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qmp: update send-key document
Date: Wed, 17 Jul 2013 16:02:46 -0400	[thread overview]
Message-ID: <20130717160246.40f1380e@redhat.com> (raw)
In-Reply-To: <1373975534-14631-1-git-send-email-akong@redhat.com>

On Tue, 16 Jul 2013 19:52:14 +0800
Amos Kong <akong@redhat.com> wrote:

> commit 9f328977 changes qmp_send_key() to accept key codes in hex,
> but the document wasn't updated. The items of keys list is union
> now, not enum.
> 
> Signed-off-by: Amos Kong <akong@redhat.com>

Applied to the qmp branch, thanks.

> ---
>  qmp-commands.hx | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index e3cbe93..30f9fc9 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -346,7 +346,8 @@ Send keys to VM.
>  Arguments:
>  
>  keys array:
> -    - "key": key sequence (a json-array of key enum values)
> +    - "key": key sequence (a json-array of key union values,
> +             union can be number or qcode enum)
>  
>  - hold-time: time to delay key up events, milliseconds. Defaults to 100
>               (json-int, optional)
> @@ -354,7 +355,9 @@ keys array:
>  Example:
>  
>  -> { "execute": "send-key",
> -     "arguments": { 'keys': [ 'ctrl', 'alt', 'delete' ] } }
> +     "arguments": { "keys": [ { "type": "qcode", "data": "ctrl" },
> +                              { "type": "qcode", "data": "alt" },
> +                              { "type": "qcode", "data": "delete" } ] } }
>  <- { "return": {} }
>  
>  EQMP

      parent reply	other threads:[~2013-07-17 20:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 11:52 [Qemu-devel] [PATCH] qmp: update send-key document Amos Kong
2013-07-16 13:30 ` Eric Blake
2013-07-17 20:02 ` Luiz Capitulino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717160246.40f1380e@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=akong@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qzhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).