From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49638)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UzXw3-00053F-R3
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 16:02:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UzXw0-0003J8-VT
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 16:02:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50895)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UzXw0-0003IB-Nb
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 16:02:48 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6HK2ldC029028
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 17 Jul 2013 16:02:47 -0400
Date: Wed, 17 Jul 2013 16:02:46 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130717160246.40f1380e@redhat.com>
In-Reply-To: <1373975534-14631-1-git-send-email-akong@redhat.com>
References: <1373975534-14631-1-git-send-email-akong@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qmp: update send-key document
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: qzhang@redhat.com, qemu-devel@nongnu.org

On Tue, 16 Jul 2013 19:52:14 +0800
Amos Kong <akong@redhat.com> wrote:

> commit 9f328977 changes qmp_send_key() to accept key codes in hex,
> but the document wasn't updated. The items of keys list is union
> now, not enum.
> 
> Signed-off-by: Amos Kong <akong@redhat.com>

Applied to the qmp branch, thanks.

> ---
>  qmp-commands.hx | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index e3cbe93..30f9fc9 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -346,7 +346,8 @@ Send keys to VM.
>  Arguments:
>  
>  keys array:
> -    - "key": key sequence (a json-array of key enum values)
> +    - "key": key sequence (a json-array of key union values,
> +             union can be number or qcode enum)
>  
>  - hold-time: time to delay key up events, milliseconds. Defaults to 100
>               (json-int, optional)
> @@ -354,7 +355,9 @@ keys array:
>  Example:
>  
>  -> { "execute": "send-key",
> -     "arguments": { 'keys': [ 'ctrl', 'alt', 'delete' ] } }
> +     "arguments": { "keys": [ { "type": "qcode", "data": "ctrl" },
> +                              { "type": "qcode", "data": "alt" },
> +                              { "type": "qcode", "data": "delete" } ] } }
>  <- { "return": {} }
>  
>  EQMP