From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uzg2C-0004xd-Hb for qemu-devel@nongnu.org; Thu, 18 Jul 2013 00:41:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uzg2A-0004aL-3y for qemu-devel@nongnu.org; Thu, 18 Jul 2013 00:41:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uzg29-0004aE-TW for qemu-devel@nongnu.org; Thu, 18 Jul 2013 00:41:42 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6I4fedR028759 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Jul 2013 00:41:41 -0400 Date: Thu, 18 Jul 2013 12:41:38 +0800 From: Fam Zheng Message-ID: <20130718044138.GA29052@T430s.nay.redhat.com> References: <1374054136-28741-1-git-send-email-famz@redhat.com> <1374054136-28741-12-git-send-email-famz@redhat.com> <51E691B9.5020605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51E691B9.5020605@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 11/11] qmp: add command 'blockdev-backup' Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Wed, 07/17 06:44, Eric Blake wrote: > On 07/17/2013 03:42 AM, Fam Zheng wrote: > > Similar to drive-backup, but this command uses a device id as target > > instead of creating/opening an image file. > > > > Signed-off-by: Fam Zheng > > --- > > blockdev.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > qapi-schema.json | 49 ++++++++++++++++++++++++++++++++++++++ > > qmp-commands.hx | 22 ++++++++++++++++++ > > 3 files changed, 142 insertions(+) > > > > > +++ b/qapi-schema.json > > @@ -1665,6 +1665,40 @@ > > '*on-target-error': 'BlockdevOnError' } } > > > > ## > > +# @BlockdevBackup > > +# > > > +{ 'type': 'BlockdevBackup', > > + 'data': { 'device': 'str', 'target': 'str', > > + 'sync': 'MirrorSyncMode', > > + '*speed': 'int', > > + '*on-source-error': 'BlockdevOnError', > > + '*on-target-error': 'BlockdevOnError' } } > > Seems okay. But what is missing is the addition of this type into the > union used for 'transaction' - shouldn't it be possible to mix this with > other transaction capabilities? > Should be possible, as users may want point-in-time snapshot of multiple disks. If this API looks OK, I will include it into transaction in the next version. -- Fam