From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzgkV-0007iJ-3k for qemu-devel@nongnu.org; Thu, 18 Jul 2013 01:27:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzgkS-0001zC-Nr for qemu-devel@nongnu.org; Thu, 18 Jul 2013 01:27:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzgkS-0001z8-GY for qemu-devel@nongnu.org; Thu, 18 Jul 2013 01:27:28 -0400 Date: Thu, 18 Jul 2013 13:27:23 +0800 From: Fam Zheng Message-ID: <20130718052723.GF29052@T430s.nay.redhat.com> References: <1373881356-3294-1-git-send-email-cngesaint@gmail.com> <1373881356-3294-6-git-send-email-cngesaint@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373881356-3294-6-git-send-email-cngesaint@gmail.com> Subject: Re: [Qemu-devel] [PATCH V3 5/7] block: Add infinite loop check in drive_init() Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xu Wang Cc: kwolf@redhat.com, stefanha@gmail.com, wdongxu@linux.vnet.ibm.com, qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com On Mon, 07/15 05:42, Xu Wang wrote: > Backing file should be checked if there is a loop in it during image > boot. Becase if there is loop qemu would no response for a long time > and segment fault occured. So this patch would check backing file > chain if there is loop in it before open image. > > Signed-off-by: Xu Wang > --- > blockdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/blockdev.c b/blockdev.c > index b3a57e0..b5f063f 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -695,6 +695,12 @@ DriveInfo *drive_init(QemuOpts *all_opts, BlockInterfaceType block_default_type) > error_report("warning: disabling copy_on_read on readonly drive"); > } > > + /* Add backing file loop check */ > + if (bdrv_backing_file_loop_check(file, drv ? drv->format_name : NULL, > + NULL, NULL)) { Would you add an error_report here, as other error paths do? > + goto err; > + } > + > ret = bdrv_open(dinfo->bdrv, file, bs_opts, bdrv_flags, drv); > bs_opts = NULL; > > -- > 1.8.1.4 > -- Fam