From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com,
qemu-devel@nongnu.org, ronniesahlberg@gmail.com
Subject: Re: [Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements
Date: Thu, 18 Jul 2013 14:36:49 +0800 [thread overview]
Message-ID: <20130718063649.GB32036@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1373544987-20613-1-git-send-email-pl@kamp.de>
On Thu, Jul 11, 2013 at 02:16:17PM +0200, Peter Lieven wrote:
> this series adds logical block provisioning functions to the iscsi layer.
> it also is the first step to the change of migration to coroutines in
> block/iscsi.
>
> the changes to qemu-img and block migration have been split and will
> follow in separte patches later.
>
> changes in v3:
> - merge both block provision inquiries into one patch. explitely free the iscsi tasks after
> the inquiry. limit the unmap to 128k blocks if the target returns max_unmap = 0xffffffff;
> - in the coroutine framework free the scsi task in the caller not in the callback. also
> change the iTask init as Kevin suggested.
> - in iscsi_co_is_allocated() return unallocated only for ANCHORED and UNALLOACTED to avoid
> a wrong return value if a new provisioning status is introduced.
> - added new patch adding .bdrv_co_discard
> - build .bdrv_co_write_zeroes on top of .bdrv_co_discard
> - fixed a bug for -ENOSPC in iscsi_create() spotted by Kevin.
> - remove support for misaligned nb_sectors in aio_readv
> - add log message in error case to lun alignment checks
>
> Peter Lieven (10):
> iscsi: add logical block provisioning information to iscsilun
> iscsi: add .bdrv_co_is_allocated
> iscsi: add .bdrv_co_discard
> iscsi: add .bdrv_write_zeroes
> block: add bdrv_write_zeroes()
> block/raw: add bdrv_co_write_zeroes
> iscsi: fix -ENOSPC in iscsi_create()
> iscsi: factor out sector conversions
> iscsi: remove support for misaligned nb_sectors in aio_readv
> iscsi: assert that sectors are aligned to LUN blocksize
>
> block.c | 27 ++-
> block/iscsi.c | 433 +++++++++++++++++++++++++++++++++++++------------
> block/raw.c | 8 +
> include/block/block.h | 2 +
> 4 files changed, 358 insertions(+), 112 deletions(-)
Thanks, applied patches 5 & 6 to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2013-07-18 6:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 12:16 [Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements Peter Lieven
2013-07-11 12:16 ` [Qemu-devel] [PATCHv3 01/10] iscsi: add logical block provisioning information to iscsilun Peter Lieven
2013-07-11 12:16 ` [Qemu-devel] [PATCHv3 02/10] iscsi: add .bdrv_co_is_allocated Peter Lieven
2013-07-11 12:16 ` [Qemu-devel] [PATCHv3 03/10] iscsi: add .bdrv_co_discard Peter Lieven
2013-07-11 12:16 ` [Qemu-devel] [PATCHv3 04/10] iscsi: add .bdrv_write_zeroes Peter Lieven
2013-07-11 12:16 ` [Qemu-devel] [PATCHv3 05/10] block: add bdrv_write_zeroes() Peter Lieven
2013-07-11 12:16 ` [Qemu-devel] [PATCHv3 06/10] block/raw: add bdrv_co_write_zeroes Peter Lieven
2013-07-11 12:16 ` [Qemu-devel] [PATCHv3 07/10] iscsi: fix -ENOSPC in iscsi_create() Peter Lieven
2013-07-11 12:16 ` [Qemu-devel] [PATCHv3 08/10] iscsi: factor out sector conversions Peter Lieven
2013-07-11 12:16 ` [Qemu-devel] [PATCHv3 09/10] iscsi: remove support for misaligned nb_sectors in aio_readv Peter Lieven
2013-07-11 12:16 ` [Qemu-devel] [PATCHv3 10/10] iscsi: assert that sectors are aligned to LUN blocksize Peter Lieven
2013-07-17 15:05 ` [Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements Paolo Bonzini
2013-07-18 8:24 ` Peter Lieven
2013-07-18 6:36 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130718063649.GB32036@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).