From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org,
owasserm@redhat.com, stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCHv4] block-migration: efficiently encode zero blocks
Date: Thu, 18 Jul 2013 17:05:20 +0800 [thread overview]
Message-ID: <20130718090520.GB9328@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1374133730-20390-1-git-send-email-pl@kamp.de>
On Thu, Jul 18, 2013 at 09:48:50AM +0200, Peter Lieven wrote:
> this patch adds a efficient encoding for zero blocks by
> adding a new flag indicating a block is completely zero.
>
> additionally bdrv_write_zeros() is used at the destination
> to efficiently write these zeroes. depending on the implementation
> this avoids that the destination target gets fully provisioned.
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>
> v3->v4:
> - rebased to current master
> - stashed migrate_zero_blocks in BlkMigState.
> - added additional comment in qapi-schema.json where to
> enable the capability.
> - added comment in the commit message about the benefit
> of using bdrv_write_zeroes().
>
> v2->v3:
> - changed type of flags in blk_send() from int to uint64_t
> - added migration capability setting to enable sending
> of zero blocks.
>
> block-migration.c | 32 ++++++++++++++++++++++++++------
> include/migration/migration.h | 1 +
> migration.c | 9 +++++++++
> qapi-schema.json | 8 +++++++-
> 4 files changed, 43 insertions(+), 7 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2013-07-18 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 7:48 [Qemu-devel] [PATCHv4] block-migration: efficiently encode zero blocks Peter Lieven
2013-07-18 9:05 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130718090520.GB9328@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).