From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UznkQ-0004kb-8O for qemu-devel@nongnu.org; Thu, 18 Jul 2013 08:55:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UznkP-0002IB-3P for qemu-devel@nongnu.org; Thu, 18 Jul 2013 08:55:54 -0400 Date: Thu, 18 Jul 2013 14:55:48 +0200 From: Kevin Wolf Message-ID: <20130718125548.GL3582@dhcp-200-207.str.redhat.com> References: <1374151939-3883-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374151939-3883-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, qemu-stable@nongnu.org, stefanha@redhat.com Am 18.07.2013 um 14:52 hat Kevin Wolf geschrieben: > Even if the VM is already stopped, we cannot assume that all data has > already been successfully flushed to disk. The flush during the previous > vm_stop() could have failed. > > Run bdrv_flush_all() unconditionally so that we get an error each time > if the block device isn't really flushed. > Oops, forgot it again: Cc: qemu-stable@nongnu.org > Signed-off-by: Kevin Wolf > --- > cpus.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/cpus.c b/cpus.c > index 8062cdd..2509eb5 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -443,11 +443,12 @@ static int do_vm_stop(RunState state) > pause_all_vcpus(); > runstate_set(state); > vm_state_notify(0, state); > - bdrv_drain_all(); > - ret = bdrv_flush_all(); > monitor_protocol_event(QEVENT_STOP, NULL); > } > > + bdrv_drain_all(); > + ret = bdrv_flush_all(); > + > return ret; > } > > @@ -1126,7 +1127,9 @@ int vm_stop_force_state(RunState state) > return vm_stop(state); > } else { > runstate_set(state); > - return 0; > + /* Make sure to return an error if the flush in a previous vm_stop() > + * failed. */ > + return bdrv_flush_all(); > } > } > > -- > 1.8.1.4 >