From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices
Date: Fri, 19 Jul 2013 12:24:10 +0800 [thread overview]
Message-ID: <20130719042410.GE29671@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1374151939-3883-1-git-send-email-kwolf@redhat.com>
On Thu, Jul 18, 2013 at 02:52:19PM +0200, Kevin Wolf wrote:
> Even if the VM is already stopped, we cannot assume that all data has
> already been successfully flushed to disk. The flush during the previous
> vm_stop() could have failed.
>
> Run bdrv_flush_all() unconditionally so that we get an error each time
> if the block device isn't really flushed.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> cpus.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2013-07-19 4:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 12:52 [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices Kevin Wolf
2013-07-18 12:55 ` Kevin Wolf
2013-07-18 13:02 ` Eric Blake
2013-07-19 4:24 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130719042410.GE29671@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).