From: Kevin Wolf <kwolf@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()
Date: Fri, 19 Jul 2013 11:14:56 +0200 [thread overview]
Message-ID: <20130719091456.GD2992@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1374136652-22567-1-git-send-email-pl@kamp.de>
Am 18.07.2013 um 10:37 hat Peter Lieven geschrieben:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index b560241..c7f0197 100644
> --- a/block.c
> +++ b/block.c
> @@ -2250,7 +2250,7 @@ int bdrv_read_unthrottled(BlockDriverState *bs, int64_t sector_num,
>
> enabled = bs->io_limits_enabled;
> bs->io_limits_enabled = false;
> - ret = bdrv_read(bs, 0, buf, 1);
> + ret = bdrv_read(bs, sector_num, buf, nb_sectors);
> bs->io_limits_enabled = enabled;
> return ret;
> }
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
The commit message would have deserved a comment about the impact. The
only caller is passing 0 as sector_num and 1 as nb_sectors, so this
doesn't change the behaviour in practice. (Which is the reason why it's
not for qemu-stable.)
Kevin
next prev parent reply other threads:[~2013-07-19 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 8:37 [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled() Peter Lieven
2013-07-18 11:02 ` Paolo Bonzini
2013-07-19 4:28 ` Stefan Hajnoczi
2013-07-19 9:14 ` Kevin Wolf [this message]
2013-07-19 9:36 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130719091456.GD2992@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).