Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup.

[Ian Main <imain@redhat.com>]

On Fri, Jul 19, 2013 at 01:41:10PM -0600, Eric Blake wrote:
> On 07/19/2013 11:03 AM, Ian Main wrote:
> > This patch adds sync-modes to the drive-backup interface and
> > implements the FULL, NONE and TOP modes of synchronization.
> > 
> 
> > Signed-off-by: Ian Main <imain@redhat.com>
> > ---
> >  block/backup.c            | 91 +++++++++++++++++++++++++++++++----------------
> >  blockdev.c                | 25 ++++++++-----
> >  include/block/block_int.h |  4 ++-
> >  qapi-schema.json          |  4 +++
> >  qmp-commands.hx           |  1 +
> >  5 files changed, 86 insertions(+), 39 deletions(-)
> > 
> 
> > +++ b/qapi-schema.json
> > @@ -1807,6 +1807,10 @@
> >  # @format: #optional the format of the new destination, default is to
> >  #          probe if @mode is 'existing', else the format of the source
> >  #
> > +# @sync: what parts of the disk image should be copied to the destination
> > +#        (all the disk, only the sectors allocated in the topmost image, or
> > +#        only new I/O).
> > +#
> >  # @mode: #optional whether and how QEMU should create a new image, default is
> >  #        'absolute-paths'.
> >  #
> 
> This hunk is still wrong.  And we still haven't answered the
> meta-question on whether @format should be mandatory (which I'd rather
> fix that first, then rebase this on top of that).

How is it wrong when it cleanly applies?  You want it separated into
another patch?

	Ian