From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0e9s-0002tC-T5 for qemu-devel@nongnu.org; Sat, 20 Jul 2013 16:53:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0e9q-0007bj-Px for qemu-devel@nongnu.org; Sat, 20 Jul 2013 16:53:40 -0400 Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:58018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0e9q-0007bG-Hm for qemu-devel@nongnu.org; Sat, 20 Jul 2013 16:53:38 -0400 Received: by mail-la0-f48.google.com with SMTP id lx15so4169741lab.7 for ; Sat, 20 Jul 2013 13:53:36 -0700 (PDT) Date: Sat, 20 Jul 2013 22:53:13 +0200 From: "Edgar E. Iglesias" Message-ID: <20130720205313.GC25811@smtp.vpn> References: <51C75FA6.6080903@reactos.org> <51C7E21A.9090005@web.de> <8A36D64D-0625-49E1-9E59-391DAEEBD1FC@suse.de> <51E91E7D.1000302@ozlabs.ru> <51E935C0.3020703@redhat.com> <51E95FDD.6080306@ozlabs.ru> <51E9E00F.6050807@ozlabs.ru> <51E9E3C4.2040002@ozlabs.ru> <51EA6256.8090501@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51EA6256.8090501@redhat.com> Subject: Re: [Qemu-devel] BUG: Re: [PATCH v3 11/14] ioport: Switch dispatching to memory core layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Liu Ping Fan , Alexey Kardashevskiy , Alexander Graf , qemu-devel , =?iso-8859-1?Q?Herv=E9?= Poussineau , "Aneesh Kumar K.V" , "anthony@codemonkey.ws" , Jan Kiszka , Andreas =?iso-8859-1?Q?F=E4rber?= , Aurelien Jarno On Sat, Jul 20, 2013 at 12:11:34PM +0200, Paolo Bonzini wrote: > Il 20/07/2013 03:11, Alexey Kardashevskiy ha scritto: > > On 07/20/2013 10:55 AM, Alexey Kardashevskiy wrote: > >> On 07/20/2013 01:48 AM, Alexey Kardashevskiy wrote: > >>> Ok. So. > >>> > >>> What broke is... > >>> I could try explaining but backtraces are lot better :) > >>> > >>> Shortly - virtio_pci_config_ops.endianness was ignored before (was bad but > >>> we had a workaround in spapr_io_ops), now it works so double swap happens > >>> and everything gets broken. > >>> > >>> If we talk about VGA (in powerpc, it is all about powerpc), I guess > >>> memory_region_iorange_write() will go through mr->ops->old_portio branch > >>> and won't do any byte swapping (so spapr_io_ops will do the job), so we are > >>> fine here. I do not understand yet why it works on mac99 though, too late > >>> here :) > >> > >> I understood. VGA does not work for mac99 either with this command line: > >> ./qemu-system-ppc64 -m "1024" -M "mac99" -vga "std" > >> So it works for pseries only because of parity bug in spapr_io_ops. > > Yes, this is what Herve was fixing for PREP too. > > > oops. I am wrong and VGA works on mac99 in upstream because isa_mmio_ops > > does the swapping in this case and portio_ops does not swap (in upstream). > > Uff... I guess we have to look at all cases for big-endian machines, and > make sure there is an odd number of exchanges. Aurelien/Alex/Herve, > where can I find images for mips malta, mips jazz, ppc4xx and prep? > Edgar, what about sh4eb (IIRC one of the two machine types supported PCI)? Sorry, I don't know (I haven't done much SH). Best regards, Edgar