From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1BRj-0002L3-4P for qemu-devel@nongnu.org; Mon, 22 Jul 2013 04:26:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1BRf-0000Ne-Cf for qemu-devel@nongnu.org; Mon, 22 Jul 2013 04:26:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1BRf-0000NS-51 for qemu-devel@nongnu.org; Mon, 22 Jul 2013 04:26:15 -0400 Date: Mon, 22 Jul 2013 10:26:09 +0200 From: Stefan Hajnoczi Message-ID: <20130722082609.GB6069@stefanha-thinkpad.redhat.com> References: <555ec78d1db05435707ae68d4af4557aea0c3beb.1372673778.git.hutao@cn.fujitsu.com> <1374399117-17527-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1374399117-17527-1-git-send-email-afaerber@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next] fdc: Improve error propagation for QOM realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Kevin Wolf , Hu Tao , qemu-devel@nongnu.org On Sun, Jul 21, 2013 at 11:31:57AM +0200, Andreas F=E4rber wrote: > Rename fdctrl_init_common() to fdctrl_realize_common() and let > fdctrl_connect_drives() propagate an Error through it. >=20 > Signed-off-by: Andreas F=E4rber > --- > hw/block/fdc.c | 40 ++++++++++++++++++++++------------------ > 1 file changed, 22 insertions(+), 18 deletions(-) Reviewed-by: Stefan Hajnoczi